Connect WelcomeView and WelcomeViewAddVehicle to App Flow by maartinj · Pull Request #301 · mikaelacaron/Basic-Car-Maintenance

maartinj · 2024-08-04T01:07:12Z

What it Does

Closes IMPROVE - Connect WelcomeView and WelcomeViewAddVehicle to App Flow #285
When app launch for the first time, will be presented OnboardingView
OnBoardingView contains 2 screens: WelcomeView and WelcomeViewAddVehicle
WelcomeView present the highlighted features of the app
WelcomeViewAddVehicle allows to add basic data about first car (Vehicle Name, Make & Model)
This pull request contains App Flow where User using the app for the first time, will see the WelcomeView, and then push WelcomeViewAddVehicle after tapping continue
Changed the "Welcome 🥳" button to be "Add Vehicle"
Once "Add Vehicle" is tapped, this Onboarding flow is dismissed, and the User, after confirming in presented alert that first vehicle data is added, should see the DashboardView. When clicked "OK" on presented alert, the app will start always from the DashboardView
Added temporary vehicle data to be presented in SettingsView as "Locally Saved Vehicle" to visualize correctly working Onboarding App Flow. This data can be deleted by swiping the added temporary vehicle data from right to the left. Temporary vehicle data is visible when app is restarted and app remember this data using UserDefaults functionality

How I Tested

Run the application in Simulator (iPhone 15 Pro, iOS 17.5), set language to 'English'
WelcomeView appear, and suddenly dismiss and shows alert "This is a Test Message From the Real Time Alert System" (I cannot turn this off. It looks like this alert is presented from server side)
Click "Dismiss" button in alert "This is a Test Message From the Real Time Alert System"
WelcomeView shows again
Click "Continue" button, WelcomeViewAddVehicle appear
Enter "Vehicle Name" in "Name" field, click "Add Vehicle" button
Alert "Vehicle Make cannot be empty! 🚗" is presented, click "OK"
Enter "Vehicle Make" in "Make" field, click "Add Vehicle" button
Alert "Vehicle Model cannot be empty! 🚗" is presented, click "OK"
Enter "Vehicle Model" in "Model" field, click "Add Vehicle" button
Alert "Congratulations! 🎉 🚙 From now on, next screen will be the main app screen" is presented, click "OK"
WelcomeViewAddVehicle dismiss, the DashboardView appear

Notes

May need further updates to include logic from SettingsView or other different task to add properly Vehicle data and delete temporary added vehicle data function

Screenshots

Screencast

onboardingFlowVideo.mp4

mikaelacaron · 2024-08-04T06:23:40Z

Great thank you! I may not get to this for a week or so to review @maartinj

mikaelacaron

Thanks so much for the contribution forever ago, and I'm just now getting to review it!
I have several comments that need resolved please. If you would like you can continue this PR and make the changes I suggested, or if you'd like to pass on this issue, you can un-assign yourself and close the PR

Once you fix everything, please click the re-review button

Basic-Car-Maintenance/Shared/Onboarding/Views/WelcomeViewAddVehicle.swift

Basic-Car-Maintenance/Shared/Settings/Views/SettingsView.swift

…p Flow

…-appflow' #Conflicts: # Basic-Car-Maintenance/Shared/Localizable.xcstrings # Basic-Car-Maintenance/Shared/Onboarding/Views/WelcomeViewAddVehicle.swift # Basic-Car-Maintenance/Shared/Settings/Views/SettingsView.swift

maartinj · 2024-10-07T12:24:16Z

I sent corrected PR. Please check and share your thoughts.

mikaelacaron

@maartinj something happened...
there's a bunch of changes reverting several PRs recently

you should merge dev into your branch

and click "resolve" for all the comments you addressed that you don't have questions on and have fixed, and then click re-review

# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Need to integrate other changes with onboarding branch # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

… App Flow

maartinj · 2024-10-08T22:04:29Z

I sent corrected PR. Fingers crossed that now is fine. Please check and share your thoughts.

mikaelacaron · 2024-10-14T10:13:54Z

@maartinj can you check, there might be a settings somewhere about when the PR was created about allowing edits from the maintainer...?
normally I'm able to commit and push to PRs, but yours isn't letting me

If you edit the description...? it'll maybe come up...? or somewhere on the right side?

maartinj · 2024-10-15T08:22:23Z

@mikaelacaron This box was unticked, do not know why:

Nevertheless, I ticked this box, so you should have access now. Please check and let me know 👍

mikaelacaron

I've made several comments about how data is passed and things to fix. I've resolved most of them, and left the comments for you, for next time!

don't change anything, I'm still deciding how I want some things to function

Basic-Car-Maintenance-Widget/Assets.xcassets/test.colorset/Contents.json

Basic-Car-Maintenance/Shared/Onboarding/Views/WelcomeView.swift

Basic-Car-Maintenance/Shared/Onboarding/Views/WelcomeViewAddVehicle.swift

mikaelacaron · 2024-10-17T08:41:22Z

Basic-Car-Maintenance/Shared/Onboarding/Views/WelcomeViewAddVehicle.swift

+            }
+        }
+
+        var message: String? {


this and the title should be a LocalizedStringResource so that they can be translated

You fixed this also, right? I see in commit 'PR 301 Suggestions, moving around functionality', in line 171, that is added with localizedStringResource?

Basic-Car-Maintenance/Shared/Onboarding/Views/WelcomeViewAddVehicle.swift

Basic-Car-Maintenance/Shared/Settings/Views/SettingsView.swift

mikaelacaron · 2024-10-17T09:16:37Z

Basic-Car-Maintenance/Shared/Onboarding/Views/WelcomeView.swift

                    HStack(spacing: 5) {
                        Text("Welcome to")
                        Text("Basic")
-                            .foregroundStyle(Color("basicGreen"))


note we don't need to use strings anymore because assets automatically generate type safe names like .basicGreen

You fixed this also, right? I see in commit 'fix colors, capitalization and comments', you changed all .basicGreen?

mikaelacaron · 2024-10-17T09:19:54Z

I'm flying today and will look back at this, don't change anything! thank you! it's almost ready to merge
@maartinj thanks for the work!

maartinj · 2024-10-19T20:55:41Z

I'm flying today and will look back at this, don't change anything! thank you! it's almost ready to merge @maartinj thanks for the work!

Sure @mikaelacaron, I am waiting for your other comments 😊👍

feat: Connect WelcomeView and WelcomeViewAddVehicle to App Flow

767d9a3

maartinj requested a review from mikaelacaron as a code owner August 4, 2024 01:07

mikaelacaron requested changes Oct 4, 2024

View reviewed changes

maartinj added 3 commits October 7, 2024 01:16

feat: Connect WelcomeView and WelcomeViewAddVehicle to App Flow

a9a411a

feat: (corrected) Connect WelcomeView and WelcomeViewAddVehicle to Ap…

13ad7a8

…p Flow

maartinj requested a review from mikaelacaron October 7, 2024 12:23

mikaelacaron requested changes Oct 8, 2024

View reviewed changes

maartinj added 2 commits October 8, 2024 23:48

feat: (corrected v2) Connect WelcomeView and WelcomeViewAddVehicle to…

63fb901

… App Flow

maartinj requested a review from mikaelacaron October 8, 2024 22:04

PR 301 Suggestions, moving around functionality

064ca37

mikaelacaron reviewed Oct 17, 2024

View reviewed changes

mikaelacaron added 2 commits October 17, 2024 12:07

remove test color

7ca3f4e

fix colors, capitalization and comments

c732c4f

mikaelacaron reviewed Oct 17, 2024

View reviewed changes

mikaelacaron added the hacktoberfest-accepted Accepted PR for Hacktoberfest label Oct 28, 2024

Uh oh!

Comments

Conversation

maartinj commented Aug 4, 2024 • edited by mikaelacaron Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What it Does

How I Tested

Notes

Screenshots

Screencast

Uh oh!

mikaelacaron commented Aug 4, 2024

Uh oh!

mikaelacaron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maartinj commented Oct 7, 2024

Uh oh!

mikaelacaron left a comment

Choose a reason for hiding this comment

Uh oh!

maartinj commented Oct 8, 2024

Uh oh!

mikaelacaron commented Oct 14, 2024

Uh oh!

maartinj commented Oct 15, 2024

Uh oh!

mikaelacaron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mikaelacaron Oct 17, 2024

Choose a reason for hiding this comment

Uh oh!

maartinj Oct 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mikaelacaron Oct 17, 2024

Choose a reason for hiding this comment

Uh oh!

maartinj Oct 19, 2024

Choose a reason for hiding this comment

Uh oh!

mikaelacaron commented Oct 17, 2024

Uh oh!

maartinj commented Oct 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maartinj commented Aug 4, 2024 •

edited by mikaelacaron

Loading