Skip to content

[#3] Fix dialogue box display issue #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihaid11 merged 1 commit into from
Nov 17, 2025
Merged

[#3] Fix dialogue box display issue #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Rpg/gamengine/RPGEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@
#include "../../GameManager.h"
#include "../inventory/ItemFactory.h"

// TODO : make the wrapText method work in order to show the NPC dialogue lines
std::vector<sf::String> wrapText(const sf::String& text, const sf::Font& font, unsigned int characterSize, float boxWidth) {
std::vector<sf::String> lines;
sf::String currentLine;
std::istringstream wordStream(text.toAnsiString()); // Convert to ANSI string for stream processing
std::istringstream wordStream(text.toAnsiString());
std::string word;

while (wordStream >> word) {
Expand Down Expand Up @@ -95,7 +94,7 @@ RPGEngine::RPGEngine(sf::RenderWindow& window, GameManager* gameManager)
std::cout << "Couldn't load font from file" << std::endl;

mDialogueText.setFont(mFont);
mDialogueText.setCharacterSize(10);
mDialogueText.setCharacterSize(13);
mDialogueText.setFillColor(sf::Color::White);
mDialogueText.setPosition(400.f, 500.f);

Expand Down Expand Up @@ -646,17 +645,18 @@ void RPGEngine::render() {
mWindow.draw(separationLine);

float textWidth = dialogueBox.getSize().x - 170.f - 40.0f;
std::vector<sf::String> lines = wrapText(mDialogueText.getString(), mFont, mDialogueText.getCharacterSize(), textWidth);
auto lines = wrapText(mDialogueText.getString(), mFont, mDialogueText.getCharacterSize(), textWidth);

float lineHeight = mDialogueText.getCharacterSize() * 1.35f;
float yOffset = dialogueBox.getPosition().y + 10.0f;
mDialogueText.setPosition(dialogueBox.getPosition().x + 158.f, yOffset);

sf::Text lineText = mDialogueText;
for (const auto& line : lines) {
mDialogueText.setString(line);
mWindow.draw(mDialogueText);
lineText.setPosition(dialogueBox.getPosition().x + 158.f, yOffset);
lineText.setString(line);
mWindow.draw(lineText);
yOffset += lineHeight;
mDialogueText.setPosition(dialogueBox.getPosition().x + 158.f, yOffset);
}

if (mNPCManager.currentNPCHasChoices())
Expand Down
Loading