Skip to content

Enhance adoption plan graph view: add padding so the bubbles don't overlap the X/Y axis #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlosthe19916 wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Enhance adoption plan graph view: add padding so the bubbles don't overlap the X/Y axis #215

Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
b52d8a0
Add container messages
carlosthe19916 Jul 8, 2021
35a3726
change message
carlosthe19916 Jul 8, 2021
781b629
message
carlosthe19916 Jul 8, 2021
3b46812
add pull_request_target
carlosthe19916 Jul 8, 2021
a453e92
Secrets
carlosthe19916 Jul 8, 2021
9326d18
pull_request
carlosthe19916 Jul 8, 2021
fea7024
github-token
carlosthe19916 Jul 8, 2021
7fff2f6
Comment
carlosthe19916 Jul 8, 2021
d056eac
2 steps
carlosthe19916 Jul 8, 2021
b7440e7
paste
carlosthe19916 Jul 8, 2021
0cb7514
message
carlosthe19916 Jul 8, 2021
c811136
Test containers
carlosthe19916 Jul 8, 2021
2e4903a
change message
carlosthe19916 Jul 8, 2021
bdd549a
script
carlosthe19916 Jul 8, 2021
33d8d36
change body
carlosthe19916 Jul 8, 2021
377de01
change body
carlosthe19916 Jul 8, 2021
9141ebc
format
carlosthe19916 Jul 8, 2021
9873d6d
Format
carlosthe19916 Jul 8, 2021
27b1e83
change message
carlosthe19916 Jul 8, 2021
96e7907
github.event.pull_request.head.repo.full_name
carlosthe19916 Jul 8, 2021
d310631
twice
carlosthe19916 Jul 8, 2021
b679e65
branch
carlosthe19916 Jul 8, 2021
8008b83
Change message content
carlosthe19916 Jul 9, 2021
86299cb
Merge branch 'main' into containerMessage
carlosthe19916 Jul 9, 2021
3b0e9b3
Change test containers name
carlosthe19916 Jul 9, 2021
6d2863c
change image name
carlosthe19916 Jul 9, 2021
25d52d5
Restore file
carlosthe19916 Jul 13, 2021
8f0d986
Add paddings
carlosthe19916 Jul 13, 2021
88ffda9
Merge branch 'main' into adoptionPlanGraphEnhancement
carlosthe19916 Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/pages/reports/components/adoption-candidate-graph/adoption-candidate-graph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,11 +317,14 @@ export const AdoptionCandidateGraph: React.FC = () => {
style={{
background: { fill: "url(#axis_gradient)" },
}}
singleQuadrantDomainPadding={false}
domainPadding={{ x: 65, y: 40 }}
>
<ChartAxis
label={t("terms.confidence")}
showGrid
tickValues={[
-5,
0,
5,
10,
Expand All @@ -343,20 +346,21 @@ export const AdoptionCandidateGraph: React.FC = () => {
90,
95,
100,
105,
]}
tickLabelComponent={<></>}
style={{
axisLabel: { fontSize: 20, padding: 30 },
axisLabel: { fontSize: 20, padding: 55 },
}}
/>
<ChartAxis
label={t("terms.businessCriticality")}
showGrid
dependentAxis
tickValues={[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]}
tickValues={[-1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11]}
tickLabelComponent={<></>}
style={{
axisLabel: { fontSize: 20, padding: 30 },
axisLabel: { fontSize: 20, padding: 80 },
}}
/>
<CartesianSquare
Expand Down