test: Enable fork-friendly Checkmarx scanning with pull_request_target#55
Merged
test: Enable fork-friendly Checkmarx scanning with pull_request_target#55
Conversation
Testing PM-19431 solution for fork PR scanning: - Changed pull_request to pull_request_target - Removed main code checkout (critical for security) - Uses new checkmarx-scan-public action from sean/PM-19431-fork-friendly-checkmarx branch - This will allow fork PRs to run Checkmarx scans Note: Depends on midnightntwrk/upload-sarif-github-action#25
gilescope
approved these changes
Sep 23, 2025
Collaborator
gilescope
left a comment
gilescope
left a comment
There was a problem hiding this comment.
We ought to default the project name correctly.
Fentonhaslam
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing the fork-friendly Checkmarx solution from PM-19431. This updates our workflow to allow fork PRs to run security scans without requiring access to secrets.
Problem
Fork PRs currently fail Checkmarx scans because they cannot access repository secrets (GitHub security feature). This blocks external contributions.
Solution
Using the new
checkmarx-scan-publicaction withpull_request_target:pull_requesttopull_request_targeteventChanges
.github/workflows/checkmarx.yaml:pull_request→pull_request_targetcheckmarx-scan-publicactionSecurity
pull_request_targetruns with base branch context (has secrets)Dependencies
Testing
Once both PRs are merged:
References
cc @gilescope