Skip to content

Conversation

@compwright
Copy link

Upgrades middlewares/utils to v4 and supporting dev dependencies

@oscarotero
Copy link
Member

thanks, but your change breaks in Php7.
Can you update the dependencies maintaining compatibility with older versions? Take a look to this example: https://github.com/middlewares/trailing-slash/blob/master/composer.json#L19-L30

@compwright
Copy link
Author

@oscarotero IMO we shouldn't be supporting PHP 7.4 anymore, it's EOL. See https://www.php.net/supported-versions.php

This PR should result in a major version release as a result.

@oscarotero
Copy link
Member

oscarotero commented Dec 4, 2024

I don't want to release a major version for this, specially if supporting php 7.x doesn't require any change in the code, only in the dependencies.

@compwright
Copy link
Author

@oscarotero the key change is this line:

"middlewares/utils": "^4.0",

Per your package.json, middlewares/utils v4 requires PHP 8.1. Therefore, this upgrade also requires a higher minimum version of PHP.

@oscarotero
Copy link
Member

You can define both versions with "middlewares/utils": "^3.0 || ^4.0". Composer will install the highest version compatible with your php version.

Take a look at the example in my first comment.

Adds support for PHP 8.4 and psr/http-message 2.x
@compwright
Copy link
Author

@oscarotero good point, updated per your request.

@oscarotero oscarotero merged commit c8c7bfc into middlewares:master Dec 5, 2024
5 checks passed
@oscarotero
Copy link
Member

Thank you!

filisko pushed a commit that referenced this pull request Mar 21, 2025
Adds support for PHP 8.4 and psr/http-message 2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants