Optional queue limit #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…limit handling. everything still works the same if a limit argument is not supplied
… the Foreman that work arrived, if `Queue.enqueued` results in something other than `:ok`, return that result to the caller
…tuple containing the atom
# Conflicts: # lib/conqueuer/util.ex # mix.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional
limitargument forConqueuer.Queueto allow you to specify a rigid queue limit and prevent additional items from being added until it burns down. I've been using this in a production environment and its worked out well.Totally understand if you don't want to add this, but figured I'd toss it your way anyhow.
Example:
If the limit argument is provided and the queue is at its limit, calling
Conqueuer.work(:some_pool, some_args)will return:limit_reached- otherwise it will return:oklike usual.Also added a couple helper functions:
Conqueuer.Queue.limit_reached?( :some_queue )- returnstrueorfalseConqueuer.Queue.limit( :some_queue )- returns integer limit size or:unlimitedI also updated the specs with these new features and added docs.