-
Notifications
You must be signed in to change notification settings - Fork 10
Fix Angular 21 upgrade issues: change detection, test mocks, and modal dropdowns #7487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
34
commits into
angular19
Choose a base branch
from
copilot/fix-expression-change-error
base: angular19
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ExpressionChangedAfterItHasBeenCheckedError on angular19
Fix NG0100 ExpressionChangedAfterItHasBeenCheckedError in EformsPageComponent
Jan 29, 2026
Member
|
@copilot rebase or make any smal change, so the github actions pr pipeline is getting triggered |
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Contributor
Author
…s components Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…n strategy Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Copilot
AI
changed the title
Fix NG0100 ExpressionChangedAfterItHasBeenCheckedError in EformsPageComponent
Fix ExpressionChangedAfterItHasBeenCheckedError in 4 components on Angular 19 upgrade
Jan 29, 2026
…nents Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Copilot
AI
changed the title
Fix ExpressionChangedAfterItHasBeenCheckedError in 4 components on Angular 19 upgrade
Fix ExpressionChangedAfterItHasBeenCheckedError in 9 components on Angular 19
Jan 29, 2026
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Copilot
AI
changed the title
Fix ExpressionChangedAfterItHasBeenCheckedError in 9 components on Angular 19
Fix unit tests broken by ChangeDetectorRef injection
Jan 29, 2026
…alogs Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Copilot
AI
changed the title
Fix Angular 21 upgrade issues: change detection errors, test mocks, and modal dropdown rendering
Fix Angular 21 upgrade issues: change detection, test mocks, and popover top layer dropdowns
Jan 29, 2026
Copilot
AI
changed the title
Fix Angular 21 upgrade issues: change detection, test mocks, and popover top layer dropdowns
Fix Angular 21 upgrade issues: change detection, test mocks, and modal dropdowns
Jan 29, 2026
…r modal dropdowns Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Copilot
AI
changed the title
Fix Angular 21 upgrade issues: change detection, test mocks, and modal dropdowns
Fix Angular 21 change detection errors and modal dropdown positioning
Jan 29, 2026
…odals Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Copilot
AI
changed the title
Fix Angular 21 change detection errors and modal dropdown positioning
Fix Angular 21 compatibility issues: change detection, test mocks, and modal dropdowns
Jan 29, 2026
…ositioning Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Copilot
AI
changed the title
Fix Angular 21 compatibility issues: change detection, test mocks, and modal dropdowns
Fix Angular 21 compatibility: lifecycle errors, test mocks, and modal dropdowns
Jan 30, 2026
Copilot
AI
changed the title
Fix Angular 21 compatibility: lifecycle errors, test mocks, and modal dropdowns
Fix Angular 21 compatibility: lifecycle, tests, and modal dropdown positioning
Jan 30, 2026
…o solution Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Copilot
AI
changed the title
Fix Angular 21 compatibility: lifecycle, tests, and modal dropdown positioning
Fix Angular 21 change detection errors and modal dropdown positioning
Jan 30, 2026
Copilot
AI
changed the title
Fix Angular 21 change detection errors and modal dropdown positioning
Fix Angular 21 upgrade issues: change detection, test mocks, and modal dropdowns
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular 21 upgrade broke component initialization, unit tests, and modal dropdowns due to stricter lifecycle rules and new dialog top-layer implementation.
Changes
Component Lifecycle
ChangeDetectorRef.markForCheck()after async data updates inngOnInit()chainsEformsPageComponent,FullLayoutComponent,FooterComponent,EntityEditCreateComponent,NavigationComponent,HeaderComponent,FoldersComponent,EntitySearchComponent,EntitySelectComponentdetectChanges()in init phase blocks subsequent async operationsUnit Test Compatibility
getParsedResult(),getCurrentLang(), event emittersonLangChange,onTranslationChange,onDefaultLangChange(required by Angular 21's TranslatePipe)Property Binding Syntax
dropdownPositionfrom string attribute to property binding:[dropdownPosition]="'bottom'"Modal Dropdown Positioning (Partial)
[appendTo]="'.cdk-overlay-pane'"to mtx-select components in modalsKnown Limitation
mtx-select dropdowns in modals remain imperfectly positioned. Angular 21's native top-layer (via
popover="manual") creates new stacking context incompatible with current mtx-select overlay implementation. TheappendToworkaround keeps dropdowns visible but positioning relative to input fields is incorrect.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.