Skip to content

Add C++17 minimum requirement to generated library #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naegelejd merged 1 commit into from
Jan 14, 2026
Merged

Add C++17 minimum requirement to generated library #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/evolution/v0/generated/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,4 @@ endif()

add_library(evo_test_generated_v0 OBJECT ${EvoTest_GENERATED_SOURCES})
target_link_libraries(evo_test_generated_v0 ${EvoTest_GENERATED_LINK_LIBRARIES})
target_compile_features(evo_test_generated_v0 PUBLIC cxx_std_17)
1 change: 1 addition & 0 deletions cpp/evolution/v1/generated/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,4 @@ endif()

add_library(evo_test_generated_v1 OBJECT ${EvoTest_GENERATED_SOURCES})
target_link_libraries(evo_test_generated_v1 ${EvoTest_GENERATED_LINK_LIBRARIES})
target_compile_features(evo_test_generated_v1 PUBLIC cxx_std_17)
1 change: 1 addition & 0 deletions cpp/evolution/v2/generated/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,4 @@ endif()

add_library(evo_test_generated OBJECT ${EvoTest_GENERATED_SOURCES})
target_link_libraries(evo_test_generated ${EvoTest_GENERATED_LINK_LIBRARIES})
target_compile_features(evo_test_generated PUBLIC cxx_std_17)
1 change: 1 addition & 0 deletions cpp/test/generated/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ list(APPEND TestModel_GENERATED_SOURCES factories.cc translator_impl.cc)

add_library(test_model_generated OBJECT ${TestModel_GENERATED_SOURCES})
target_link_libraries(test_model_generated ${TestModel_GENERATED_LINK_LIBRARIES})
target_compile_features(test_model_generated PUBLIC cxx_std_17)

add_library(test_model_generated_mocks OBJECT mocks.cc)
target_link_libraries(test_model_generated_mocks
Expand Down
1 change: 1 addition & 0 deletions tooling/internal/cpp/cmake.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ endif()

fmt.Fprintf(w, "add_library(%s OBJECT ${%s_SOURCES})\n", objectLibraryName, cmakePrefix)
fmt.Fprintf(w, "target_link_libraries(%s ${%s_LINK_LIBRARIES})\n", objectLibraryName, cmakePrefix)
fmt.Fprintf(w, "target_compile_features(%s PUBLIC cxx_std_17)\n", objectLibraryName)

if options.InternalGenerateMocks {
w.WriteStringln("")
Expand Down
Loading