-
Notifications
You must be signed in to change notification settings - Fork 275
Allow methods returning IIterable<T> to be used as synchronous generators #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Fulgen301
wants to merge
10
commits into
microsoft:master
Choose a base branch
from
Fulgen301:user/Fulgen301/iiterable-generator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6dc6c18
Allow methods returning IIterable<T> to be used as synchronous genera…
Fulgen301 d4f4f48
Add test cases
Fulgen301 a2e9ae3
Constrain the generator implementation to `IIterator<T>` and add
Fulgen301 fc62916
Throw winrt::hresult_out_of_bounds when the iterator is at the end
Fulgen301 adbe1bd
Add missing @cond / @endcond for wil::details
Fulgen301 84affac
Merge branch 'master' into user/Fulgen301/iiterable-generator
jonwis f58cdcb
Rename make_iterable_from_iterator to make_iterable_from_generator
Fulgen301 7d038a6
Rename make_iterable_from_iterator to make_iterable_from_generator in…
Fulgen301 0a19f62
Merge branch 'master' into user/Fulgen301/iiterable-generator
dunhor 3888b11
Merge branch 'master' into user/Fulgen301/iiterable-generator
dunhor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding a way to keep a strong or weak reference to a class here, as well as a pointer. Maybe something similar to C++/WinRT's delegate implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
Funcaccepts those arguments, it's already possible (e.g. calling a member function with a strong reference that is stored in theIIterable<T>helper withwil::make_iterable_from_iterator(&Foo::Bar, get_strong()). That doesn't work with weak references, but what would the semantics be if the weak pointer's object has been destroyed? ShouldFirstreturn an empty iterator?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A member function pointer won't take a strong reference as argument directly via std::invoke/std::apply.
Good point reguarding weak references, lets just ignore that for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah looks like std::invoke will try
(*arg).(*f)(), I did not know that. Nothing to do here, then.