Skip to content

Fix test:desktop task in wasm-wasi-core#252

Draft
Copilot wants to merge 3 commits intomainfrom
copilot/fix-test-desktop-task
Draft

Fix test:desktop task in wasm-wasi-core#252
Copilot wants to merge 3 commits intomainfrom
copilot/fix-test-desktop-task

Conversation

Copy link

Copilot AI commented Feb 20, 2026

The test:desktop task in wasm-wasi-core had two bugs: worker test failures were silently swallowed (making the task always appear to pass), and esbuild wasn't run before testing (leaving dist/desktop/extension.js missing for VS Code extension activation).

Changes

  • wasm-wasi-core/src/desktop/test/index.ts: Remove catch blocks around doRunWorkerTests calls so worker test failures propagate instead of being logged and discarded. finally blocks are preserved to ensure workspace cleanup always runs.
// Before — failures silently discarded
try {
    await doRunWorkerTests(workspaceContent, true);
} catch (error) {
    console.error(error);
} finally { /* cleanup */ }

// After — failures propagate, cleanup still guaranteed
try {
    await doRunWorkerTests(workspaceContent, true);
} finally { /* cleanup */ }
  • wasm-wasi-core/package.json: Prefix test:desktop with npm run esbuild to build dist/desktop/extension.js before launching VS Code, matching the existing pattern in test:web.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • update.code.visualstudio.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node ./lib/desktop/test/runTests.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 20, 2026 23:11
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix test for desktop task Fix test:desktop task in wasm-wasi-core Feb 20, 2026
Copilot AI requested a review from rzhao271 February 20, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants