This repository was archived by the owner on May 2, 2022. It is now read-only.
Caching the datasource get calls for a CD set up.#184
Open
anuragc617 wants to merge 8 commits intomasterfrom
Open
Caching the datasource get calls for a CD set up.#184anuragc617 wants to merge 8 commits intomasterfrom
anuragc617 wants to merge 8 commits intomasterfrom
Conversation
anuragc617
requested review from
bishal-pdMSFT,
kanika1894 and
vineetmimrot
as code owners
vineetmimrot
reviewed
Oct 9, 2020
| const requestBody = !!dataSource.requestBody ? MustacheHelper.render(dataSource.requestBody, view) : null; | ||
| const armClient = new ArmRestClient(azureSession); | ||
| let result: any; | ||
| if (httpMethod == "GET" && Cache.getCache().getValue(armUri)) { |
Member
There was a problem hiding this comment.
Instead of checking at everyplace, whether the request is cached or not, Should we create a cache client which will check the URL in the map and if it is already processed then return cache result like https://www.npmjs.com/package/cacheable-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.