Fix copy buttons not appearing in search results #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed getElementsByTagName('div') to getElementsByClassName('icon') to prevent
the search filter from hiding child elements like .copy-buttons.
Also added 'let' declaration to the loop variable 'i' for consistency.
Co-authored-by: hawkticehurst <39639992+hawkticehurst@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add copy buttons to icon search results
Fix copy buttons not appearing in search results
Jan 23, 2026
hawkticehurst
approved these changes
Jan 26, 2026
hawkticehurst
approved these changes
Jan 26, 2026
joaomoreno
approved these changes
Jan 26, 2026
dmitrivMS
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy name/SVG buttons were hidden when hovering over icons in search results, though they worked correctly in the main view.
Root Cause
The search filter used
getElementsByTagName('div')which selected all divs inside#icons, including child.copy-buttonscontainers. These child divs lackdata-nameattributes, so they were set todisplay: noneduring filtering.Changes
getElementsByTagName('div')togetElementsByClassName('icon')to only filter icon containers, not their childrenletdeclaration to loop variable for consistencyBefore/After
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.