Port Regular Expressions checking#3061
Merged
jakebailey merged 44 commits intomicrosoft:mainfrom Mar 16, 2026
Merged
Conversation
Co-authored-by: =?UTF-8?q?=E5=BD=A2=E7=B4=A0=E5=8F=A2=E9=9B=86=E3=83=BB=E3=81=90?= =?UTF-8?q?=E3=82=89=E3=81=B5=E3=81=83=E3=83=BC=E3=82=80?= <graphemecluster@gmail.com>
Co-authored-by: graphemecluster <graphemecluster@gmail.com>
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Co-authored-by: Ron Buckton <ron.buckton@microsoft.com>
Co-authored-by: graphemecluster <graphemecluster@gmail.com>
… in Regular Expressions" Co-authored-by: graphemecluster <graphemecluster@gmail.com>
Co-authored-by: graphemecluster <graphemecluster@gmail.com>
Member
|
Can you see if this works with the tests added in #2107? |
Contributor
Author
|
It doesn't report the exact same errors as that PR in the |
Member
|
Okay. Strada alignment is of course good 😄 |
jakebailey
reviewed
Mar 12, 2026
jakebailey
reviewed
Mar 12, 2026
jakebailey
reviewed
Mar 12, 2026
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
This all looks great; much appreciated! Only minor comments.
Member
|
In general, I would recheck that all of the comments are present too. |
jakebailey
reviewed
Mar 16, 2026
jakebailey
reviewed
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to be a pretty faithful port of the existing code.
closes #3044