This repository was archived by the owner on Jun 11, 2020. It is now read-only.
Add dependencies for import types #767
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sandersn
suggested changes
Jun 9, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Looks good; same comment as others: needs a test and port to microsoft/DefinitelyTyped-tools
| } | ||
|
|
||
| default: | ||
| ts.forEachChild(node, recur); |
Member
There was a problem hiding this comment.
Does this also fix microsoft/DefinitelyTyped-tools#44? Probably not, but the additional tree walking surely makes some difference.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #575