Skip to content

Conversation

@wirthual
Copy link
Contributor

Allow passing of endpoint_envvar into constructor and check if provided value matches with model_to_embedding_size_and_envvar if entry for model exists.

Copy link
Collaborator

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind running the code though black (make format in the repo) and adding a unittest to test/test_embeddings.py?

@gvanrossum-ms
Copy link
Collaborator

Also would be nice to merge with main before re-submitting.

(Let me know if my requirements are starting to feel onerous -- we can make other arrangements, I want you to be a happy contributor.)

@wirthual
Copy link
Contributor Author

Also would be nice to merge with main before re-submitting.

(Let me know if my requirements are starting to feel onerous -- we can make other arrangements, I want you to be a happy contributor.)

No problem, clear guidance and feedback is very helpful. Merged back main and added a unit test.

@gvanrossum-ms
Copy link
Collaborator

Looks like your tests are failing. The fix is probably simple enough. To check that you've got it, run "make check test format" locally before committing and pushing.

Copy link
Collaborator

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvanrossum gvanrossum merged commit 6d9e498 into microsoft:main Oct 22, 2025
12 checks passed
@gvanrossum
Copy link
Collaborator

gvanrossum commented Oct 22, 2025

W00t! Thanks for persevering. Curious what you're planning to do with typeagent, and how I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants