Fix #149 pydantic configuration / setup to cover remaining warnings/errors #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bmerkle
commented
Jan 3, 2026
bmerkle
commented
- fixed No parameter named "xyz "PyrightreportCallIssue for dataclasses, e.g. class Term
- fix for Fix pydantic configuration / setup to cover remaining warnings/errors #149
gvanrossum
reviewed
Jan 3, 2026
Collaborator
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
I'm skeptical that this is the right fix.
And maybe this should import dataclass from .dataclasses? (I.e. src/typeagent/knowpro/dataclasses.py, which you introduced to fix this?!?!)
Add pyright to development dependencies and update .gitignore for .venv the real issue was the pyright version bundeled in the VSCode plugins (either VSCode-pyright or VSCode-pylance plugin). See issue microsoft#149
gvanrossum
approved these changes
Jan 5, 2026
Collaborator
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
I do wonder if things wouldn't be much easier if we just recommended not to install the standalone Pyright plugin and rely on Pylance? That's what I do and I don't see the problem. I have not messed with the Pylance version. But it's quite possible that on Windows things are different. (I can't test that right now.)
I'll just merge and we can tweak later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.