-
Notifications
You must be signed in to change notification settings - Fork 41
125-examples: move various ancillary dirs into subdirs #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- moved demo to examples/demo - moved samples to examples/samples - moved gmail to tools/gmail - moved spec to docs/spec later we can delete/update outdated code/doc etc - adopted make and config files, ci, gitignore - adopted links in documentation - removed usused import in simple_query_demo.py
|
strange i do not have any line like this in my commit ? |
This is because CI uses ci.yml from the main branch, always. |
|
As I said, CI fails because it is using the old ci.yml from main. Please ignore the CI. @bmerkle just fix the .gitignore and then I'll approve and merge. I have an idea to make this a less frequent issue: we can put the list of folders to check and format in e.g. sources.txt file, and put in ci.yml something like |
have you made review for .gitignore ? i do not see a comment or requested changes in github UI |
.gitignore
Outdated
| /examples/testdata/Episode_53_Answer_results.json | ||
| /examples/testdata/Episode_53_Search_results.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be /tests/ instead of /examples/
Sorry I did it on my phone which failed to send the comment. Redid it now. /examples/testdata/ should be /tests/testdata/. |
|
Oh, looks like test_mcp.py is failing because it references a file in testdata, which was moved. |
right, should be fixed now. Currently the path are kind of hardcoded and we have some code duplication. |
gvanrossum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Maybe a fixture that computes the path of testdata? Or even several for the paths of commonly used test data files? |
fix part3+4 for #125