Add --force flag to tools/release.py and remove 'except Exception' #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
changed the title
robgruen
reviewed
Nov 23, 2025
tools/release.py
Outdated
| if args.force: | ||
| print( | ||
| f"Error: New version {args.version} must be higher than current version {current_version}", | ||
| f"Warning: New version {args.version} precedes current version {current_version}. (forced)" |
Collaborator
There was a problem hiding this comment.
nit: "matches or precedes"
robgruen
approved these changes
Nov 23, 2025
robgruen
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you want to push an earlier release or while the repo is dirty. Use
--forceto disable the errors for those cases.Remove two
try://except Exception as e: print(e); returnblocks, they don't help anything (expected exceptions aren't handled this way, and for unexpected ones I strongly prefer to get the full traceback.