Allow for Transformer layers operating on densely connected graph #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pashminacameron
approved these changes
Jul 12, 2020
| D ~ vertex representation _d_imension | ||
| H ~ attention _h_ead size | ||
| N ~ _n_um attention heads | ||
| P ~ _n_number of node pairs in total, where P = sum(graph_size**2 for graph_size in batch) |
Contributor
There was a problem hiding this comment.
P ~ number of node _p_airs in total
|
|
||
| # Compute attention scores between queries and keys by doing an inner product, | ||
| # normalised by the square root of the representation size. | ||
| scores = tf.einsum( |
Contributor
There was a problem hiding this comment.
I find it useful to keep information about which kind of attention is being implemented when there is an einsum involved in a comment, for example: Attention(Q, K) = softmax(Q K^T/sqrt(D)) ?
Contributor
Author
There was a problem hiding this comment.
Eh, I included the comment above the einsum to clarify the attention kind, but I think what you mean is you would prefer to have it as a math-y formula as well?
Contributor
There was a problem hiding this comment.
Yes, I meant the formula, but it's not a biggy. Sorry I forgot about this one - It's easy to forget these PRs exist in amongst all the VSTS noise..
pashminacameron
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.