Skip to content

Conversation

@Hotell
Copy link

@Hotell Hotell commented Mar 12, 2025

@Hotell Hotell changed the title Fix/get stories v2 fix: properly process result of extract() which is an object instead of array Mar 12, 2025
@Hotell Hotell marked this pull request as ready for review March 12, 2025 15:42
children: PropTypes.any,
steps: PropTypes.array,
isStowrWrightComponent: PropTypes.bool
isStowrWrightComponent: PropTypes.bool,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it common practice to have "," EOL char for the last property of JSON?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi that's not json - outcome of prettier -w , trailing commas are part of ECMA standard and JSONC standard AFAIR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, didnt know about that.

@Hotell Hotell force-pushed the fix/get-stories-v2 branch from 3f704a7 to 619a38f Compare March 25, 2025 14:20
@Hotell Hotell requested a review from sunilsurana March 25, 2025 14:21
@sunilsurana sunilsurana merged commit 022eabf into microsoft:storybook7 Mar 25, 2025
2 checks passed
@sunilsurana
Copy link
Member

Published in storywright@0.0.27-storybook7.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants