Skip to content

Prompt telemetry#170

Open
Christina-Kang wants to merge 4 commits intomicrosoft:masterfrom
Christina-Kang:prompt-telemetry
Open

Prompt telemetry#170
Christina-Kang wants to merge 4 commits intomicrosoft:masterfrom
Christina-Kang:prompt-telemetry

Conversation

@Christina-Kang
Copy link
Contributor

Prompt user for telemetry on first use.

Verified:

  • Build and test CI passes
  • History and readme updated to reflect changes
  • Package version updated according to semantic versioning rules
  • Tests modified or added, when applicable
  • Updated code owners file, when applicable
  • Read the PR checklist

@coveralls
Copy link

coveralls commented Dec 19, 2018

Coverage Status

Coverage decreased (-0.6%) to 83.271% when pulling 8c08df1 on Christina-Kang:prompt-telemetry into 042c2f9 on Microsoft:master.

jeffj6123
jeffj6123 previously approved these changes Dec 19, 2018

user_response = None

while user_response not in ['y', 'yes', 'n', 'no']:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does knack have any prompting features we should be using for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. Will look it up before merging this change in - this change will not be part of 7.1.0

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants