Skip to content

fixed the show settings for debg cert manager #5493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheLarkInn merged 3 commits into from
Dec 12, 2025
Merged

fixed the show settings for debg cert manager #5493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1756ff3
fixed the show settings for debg cert manager
yashwanth195 Dec 9, 2025
bf3e731
[debug-cert-manager]correctly declared the constants
yashwanth195 Dec 11, 2025
babfc24
Update vscode-extensions/debug-certificate-manager-vscode-extension/s…
yashwanth195 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vscode-extensions/debug-certificate-manager-vscode-extension/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

export const EXTENSION_DISPLAY_NAME: string = 'Debug Certificate Manager';

export const EXTENSION_ID: string = 'RushStack.debug-certificate-manager';
export const EXTENSION_ID: string = '@ext:ms-RushStack.debug-certificate-manager';
Copy link
Member

@bmiddha bmiddha Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: @ext is a setting prefix to look for extension id and not part of the extension id itself. consider renaming the const to SETTINGS_EXTENSION_ID_FILTER or keep the string concatenation in extention.ts

Also, See if you can source this info from the extension manifest to avoid future issues like this. We can also start using that pattern for other vscode extensions here.

import packageJson from '../package.json';
// ....
export const EXTENSION_ID: string = `${packageJson.publisher}.${packageJson.name}`

Copy link
Member

@bmiddha bmiddha Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or something like

import packageJson from '../package.json';
// ....
export const EXTENSION_ID: string = `${packageJson.publisher}.${packageJson.name}`;
export const VSCODE_SETTINGS_EXTENSION_ID_FILTER = `@ext:${EXTENSION_ID}`;


export const COMMAND_PREFIX: string = 'debugCertificateManager';
export const COMMAND_SYNC: string = `${COMMAND_PREFIX}.sync`;
Expand Down
2 changes: 1 addition & 1 deletion vscode-extensions/debug-certificate-manager-vscode-extension/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export function activate(context: vscode.ExtensionContext): void {
}

async function handleShowSettings(): Promise<void> {
await vscode.commands.executeCommand(VSCODE_COMMAND_WORKSPACE_OPEN_SETTINGS, `@ext:${EXTENSION_ID}`);
await vscode.commands.executeCommand(VSCODE_COMMAND_WORKSPACE_OPEN_SETTINGS, EXTENSION_ID);
}

async function handleSync(): Promise<void> {
Expand Down