fixed the show settings for debg cert manager #5493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@yashwanth195 for pull requests if you have an issue that this PR fixes add in the description
GitHub will then link the issue and close it when the PR is merged. |
Contributor
Author
|
Fixes issue #5491. |
TheLarkInn
approved these changes
Dec 12, 2025
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
dmichon-msft
approved these changes
Dec 12, 2025
vscode-extensions/debug-certificate-manager-vscode-extension/src/extension.ts
Outdated
Show resolved
Hide resolved
…rc/extension.ts Correct expression Co-authored-by: David Michon <dmichon@microsoft.com>
TheLarkInn
approved these changes
Dec 12, 2025
bmiddha
reviewed
Dec 15, 2025
| export const EXTENSION_DISPLAY_NAME: string = 'Debug Certificate Manager'; | ||
|
|
||
| export const EXTENSION_ID: string = 'RushStack.debug-certificate-manager'; | ||
| export const EXTENSION_ID: string = '@ext:ms-RushStack.debug-certificate-manager'; |
Member
There was a problem hiding this comment.
nit: @ext is a setting prefix to look for extension id and not part of the extension id itself. consider renaming the const to SETTINGS_EXTENSION_ID_FILTER or keep the string concatenation in extention.ts
Also, See if you can source this info from the extension manifest to avoid future issues like this. We can also start using that pattern for other vscode extensions here.
import packageJson from '../package.json';
// ....
export const EXTENSION_ID: string = `${packageJson.publisher}.${packageJson.name}`
Member
There was a problem hiding this comment.
or something like
import packageJson from '../package.json';
// ....
export const EXTENSION_ID: string = `${packageJson.publisher}.${packageJson.name}`;
export const VSCODE_SETTINGS_EXTENSION_ID_FILTER = `@ext:${EXTENSION_ID}`;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"[ts-command-line] Add support for numeric command line parameters"
Fixes issue #5491
Details
Changed initialized constant reflecting the correct path.