[debug-certificate-manager] improve shell output parsing when resolving remote workspace's homedir #5488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
reviewed
Dec 8, 2025
vscode-extensions/debug-certificate-manager-vscode-extension/package.json
Show resolved
Hide resolved
iclanton
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issues where homedir resolution does not work as expected with
zshandfishDetails
Fix bug where the homedir path has extra characters coming from different shell behaviors.
This fix adds start and end markers to the desired node output which helps trim the shell output.
How it was tested
Tested with
bash,zsh,fishas default vscode shellsImpacted documentation