Skip to content

Bump ESLint #5408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iclanton merged 16 commits into from
Oct 11, 2025
Merged

Bump ESLint #5408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
940325d
Bump decoupled local dependencies.
iclanton Oct 7, 2025
a2744ce
Bump ESLint.
iclanton Oct 7, 2025
853f6c9
Bump eslint in decoupled local dependencies.
iclanton Oct 7, 2025
cf6f7da
fixup! Bump ESLint.
iclanton Oct 7, 2025
594533c
fixup! Bump ESLint.
iclanton Oct 7, 2025
2c869ab
Rush change.
iclanton Oct 7, 2025
dc91dd7
Include 9.37.0 in supported ESLint versions in eslint-bulk.
iclanton Oct 7, 2025
1a07014
Rush update.
iclanton Oct 7, 2025
5ef37d0
Log more information in the bulk suppression tests.
iclanton Oct 9, 2025
c0af74f
fixup! Include 9.37.0 in supported ESLint versions in eslint-bulk.
iclanton Oct 9, 2025
3cfc797
fixup! Include 9.37.0 in supported ESLint versions in eslint-bulk.
iclanton Oct 9, 2025
0af9746
Deduplicate a few constants.
iclanton Oct 10, 2025
047dc39
fixup! Rush update.
iclanton Oct 10, 2025
b61a284
Revert "fixup! Include 9.37.0 in supported ESLint versions in eslint-…
iclanton Oct 10, 2025
bd0793c
Test with 9.37.0
iclanton Oct 10, 2025
06efb7b
Fix tests.
iclanton Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/api-documenter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@rushstack/heft": "workspace:*",
"@types/js-yaml": "4.0.9",
"@types/resolve": "1.20.2",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-node-rig": "workspace:*"
}
}
4 changes: 2 additions & 2 deletions apps/api-extractor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@
"typescript": "5.8.2"
},
"devDependencies": {
"@rushstack/heft": "1.0.0",
"@rushstack/heft": "1.1.0",
"@types/lodash": "4.14.116",
"@types/resolve": "1.20.2",
"@types/semver": "7.5.0",
"decoupled-local-node-rig": "workspace:*",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*"
}
}
2 changes: 1 addition & 1 deletion apps/cpu-profile-summarizer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"devDependencies": {
"@rushstack/heft": "workspace:*",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-node-rig": "workspace:*"
}
}
4 changes: 2 additions & 2 deletions apps/heft/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@
},
"devDependencies": {
"@microsoft/api-extractor": "workspace:*",
"@rushstack/heft": "1.0.0",
"@rushstack/heft": "1.1.0",
"@types/watchpack": "2.4.0",
"decoupled-local-node-rig": "workspace:*",
"eslint": "~9.25.1"
"eslint": "~9.37.0"
}
}
2 changes: 1 addition & 1 deletion apps/lockfile-explorer-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@rushstack/heft": "workspace:*",
"@types/react": "17.0.74",
"@types/react-dom": "17.0.25",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-web-rig": "workspace:*",
"typescript": "5.8.2"
}
Expand Down
2 changes: 1 addition & 1 deletion apps/lockfile-explorer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@types/express": "4.17.21",
"@types/js-yaml": "4.0.9",
"@types/update-notifier": "~6.0.1",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-node-rig": "workspace:*",
"@pnpm/lockfile.types": "1002.0.1",
"@pnpm/types": "1000.8.0",
Expand Down
2 changes: 1 addition & 1 deletion apps/rundown/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
},
"devDependencies": {
"@rushstack/heft": "workspace:*",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-node-rig": "workspace:*"
}
}
2 changes: 1 addition & 1 deletion apps/rush-mcp-server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
},
"devDependencies": {
"@rushstack/heft": "workspace:*",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-node-rig": "workspace:*",
"typescript": "~5.8.2",
"@types/node": "20.17.19"
Expand Down
2 changes: 1 addition & 1 deletion apps/rush/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
},
"devDependencies": {
"@rushstack/heft": "workspace:*",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-node-rig": "workspace:*",
"@rushstack/rush-amazon-s3-build-cache-plugin": "workspace:*",
"@rushstack/rush-azure-storage-build-cache-plugin": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion apps/trace-import/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@rushstack/heft": "workspace:*",
"@types/resolve": "1.20.2",
"@types/semver": "7.5.0",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-node-rig": "workspace:*"
}
}
2 changes: 1 addition & 1 deletion apps/zipsync/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"devDependencies": {
"@rushstack/heft": "workspace:*",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-node-rig": "workspace:*"
}
}
2 changes: 1 addition & 1 deletion build-tests-samples/heft-node-basic-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@rushstack/heft-typescript-plugin": "workspace:*",
"@types/heft-jest": "1.0.1",
"@types/node": "20.17.19",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
}
Expand Down
2 changes: 1 addition & 1 deletion build-tests-samples/heft-node-jest-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@rushstack/heft-typescript-plugin": "workspace:*",
"@types/heft-jest": "1.0.1",
"@types/node": "20.17.19",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
}
Expand Down
2 changes: 1 addition & 1 deletion build-tests-samples/heft-node-rig-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"@rushstack/heft-node-rig": "workspace:*",
"@types/heft-jest": "1.0.1",
"@types/node": "20.17.19",
"eslint": "~9.25.1"
"eslint": "~9.37.0"
}
}
2 changes: 1 addition & 1 deletion build-tests-samples/heft-serverless-stack-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@types/node": "20.17.19",
"aws-cdk-lib": "2.189.1",
"constructs": "~10.0.98",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
}
Expand Down
2 changes: 1 addition & 1 deletion build-tests-samples/heft-storybook-react-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@types/react-dom": "17.0.25",
"@types/webpack-env": "1.18.8",
"css-loader": "~5.2.7",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"heft-storybook-react-tutorial-storykit": "workspace:*",
"html-webpack-plugin": "~4.5.2",
"local-eslint-config": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion build-tests-samples/heft-web-rig-app-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@types/react": "17.0.74",
"@types/react-dom": "17.0.25",
"@types/webpack-env": "1.18.8",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*"
}
}
2 changes: 1 addition & 1 deletion build-tests-samples/heft-web-rig-library-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@types/react-dom": "17.0.25",
"@types/react": "17.0.74",
"@types/webpack-env": "1.18.8",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*"
}
}
2 changes: 1 addition & 1 deletion build-tests-samples/heft-webpack-basic-tutorial/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@types/react-dom": "17.0.25",
"@types/webpack-env": "1.18.8",
"css-loader": "~6.6.0",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"html-webpack-plugin": "~5.5.0",
"local-eslint-config": "workspace:*",
"source-map-loader": "~3.0.1",
Expand Down
2 changes: 1 addition & 1 deletion build-tests/api-documenter-scenarios/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"@microsoft/api-extractor": "workspace:*",
"@rushstack/heft": "workspace:*",
"@rushstack/node-core-library": "workspace:*",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-node-rig": "workspace:*",
"run-scenarios-helpers": "workspace:*"
}
Expand Down
2 changes: 1 addition & 1 deletion build-tests/api-documenter-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@microsoft/api-extractor": "workspace:*",
"@rushstack/heft": "workspace:*",
"@rushstack/node-core-library": "workspace:*",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-node-rig": "workspace:*"
}
}
2 changes: 1 addition & 1 deletion build-tests/api-extractor-test-05/dist/tsdoc-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"toolPackages": [
{
"packageName": "@microsoft/api-extractor",
"packageVersion": "7.52.15"
"packageVersion": "7.53.0"
}
]
}
2 changes: 1 addition & 1 deletion build-tests/eslint-8-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"@rushstack/eslint-config": "workspace:*",
"@rushstack/heft": "workspace:*",
"@types/node": "20.17.19",
"@typescript-eslint/parser": "~8.31.0",
"@typescript-eslint/parser": "~8.46.0",
"eslint": "~8.57.0",
"local-node-rig": "workspace:*",
"typescript": "~5.8.2"
Expand Down
4 changes: 2 additions & 2 deletions build-tests/eslint-9-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"@rushstack/heft": "workspace:*",
"local-node-rig": "workspace:*",
"@types/node": "20.17.19",
"@typescript-eslint/parser": "~8.31.0",
"eslint": "~9.25.1",
"@typescript-eslint/parser": "~8.46.0",
"eslint": "~9.37.0",
"typescript": "~5.8.2"
}
}
23 changes: 11 additions & 12 deletions build-tests/eslint-bulk-suppressions-test-flat/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,21 +65,20 @@ for (const runFolderPath of RUN_FOLDER_PATHS) {
);
const shellPathWithEslint = `${dependencyBinFolder}${path.delimiter}${process.env['PATH']}`;

const executableResult = Executable.spawnSync(
process.argv0,
[eslintBulkStartPath, 'suppress', '--all', 'src'],
{
currentWorkingDirectory: folderPath,
environment: {
...process.env,
PATH: shellPathWithEslint,
[ESLINT_PACKAGE_NAME_ENV_VAR_NAME]: eslintPackageName
}
const args = [eslintBulkStartPath, 'suppress', '--all', 'src'];
const executableResult = Executable.spawnSync(process.argv0, args, {
currentWorkingDirectory: folderPath,
environment: {
...process.env,
PATH: shellPathWithEslint,
[ESLINT_PACKAGE_NAME_ENV_VAR_NAME]: eslintPackageName
}
);
});

if (executableResult.status !== 0) {
console.error('The eslint-bulk-suppressions command failed.');
console.error(
`The eslint-bulk-suppressions command (\`node ${args.join(' ')}\` in ${folderPath}) failed.`
);
console.error('STDOUT:');
console.error(executableResult.stdout.toString());
console.error('STDERR:');
Expand Down
0 ...ent/.eslint-bulk-suppressions-9.25.1.json → ...ent/.eslint-bulk-suppressions-9.37.0.json
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions build-tests/eslint-bulk-suppressions-test-flat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"@rushstack/eslint-patch": "workspace:*",
"@rushstack/heft": "workspace:*",
"@rushstack/node-core-library": "workspace:*",
"@typescript-eslint/parser": "~8.31.0",
"eslint": "~9.25.1",
"@typescript-eslint/parser": "~8.46.0",
"eslint": "~9.37.0",
"local-node-rig": "workspace:*",
"typescript": "~5.8.2"
}
Expand Down
0 ...ver/.eslint-bulk-suppressions-9.25.1.json → ...ver/.eslint-bulk-suppressions-9.37.0.json
View file
Open in desktop
File renamed without changes.
23 changes: 11 additions & 12 deletions build-tests/eslint-bulk-suppressions-test-legacy/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,21 +65,20 @@ for (const runFolderPath of RUN_FOLDER_PATHS) {
);
const shellPathWithEslint = `${dependencyBinFolder}${path.delimiter}${process.env['PATH']}`;

const executableResult = Executable.spawnSync(
process.argv0,
[eslintBulkStartPath, 'suppress', '--all', 'src'],
{
currentWorkingDirectory: folderPath,
environment: {
...process.env,
PATH: shellPathWithEslint,
[ESLINT_PACKAGE_NAME_ENV_VAR_NAME]: eslintPackageName
}
const args = [eslintBulkStartPath, 'suppress', '--all', 'src'];
const executableResult = Executable.spawnSync(process.argv0, args, {
currentWorkingDirectory: folderPath,
environment: {
...process.env,
PATH: shellPathWithEslint,
[ESLINT_PACKAGE_NAME_ENV_VAR_NAME]: eslintPackageName
}
);
});

if (executableResult.status !== 0) {
console.error('The eslint-bulk-suppressions command failed.');
console.error(
`The eslint-bulk-suppressions command (\`node ${args.join(' ')}\` in ${folderPath}) failed.`
);
console.error('STDOUT:');
console.error(executableResult.stdout.toString());
console.error('STDERR:');
Expand Down
2 changes: 1 addition & 1 deletion build-tests/eslint-bulk-suppressions-test-legacy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@rushstack/eslint-patch": "workspace:*",
"@rushstack/heft": "workspace:*",
"@rushstack/node-core-library": "workspace:*",
"@typescript-eslint/parser": "~8.31.0",
"@typescript-eslint/parser": "~8.46.0",
"eslint": "~8.57.0",
"eslint-8.23": "npm:eslint@8.23.1",
"eslint-oldest": "npm:eslint@8.6.0",
Expand Down
23 changes: 11 additions & 12 deletions build-tests/eslint-bulk-suppressions-test/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,21 +65,20 @@ for (const runFolderPath of RUN_FOLDER_PATHS) {
);
const shellPathWithEslint = `${dependencyBinFolder}${path.delimiter}${process.env['PATH']}`;

const executableResult = Executable.spawnSync(
process.argv0,
[eslintBulkStartPath, 'suppress', '--all', 'src'],
{
currentWorkingDirectory: folderPath,
environment: {
...process.env,
PATH: shellPathWithEslint,
[ESLINT_PACKAGE_NAME_ENV_VAR_NAME]: eslintPackageName
}
const args = [eslintBulkStartPath, 'suppress', '--all', 'src'];
const executableResult = Executable.spawnSync(process.argv0, args, {
currentWorkingDirectory: folderPath,
environment: {
...process.env,
PATH: shellPathWithEslint,
[ESLINT_PACKAGE_NAME_ENV_VAR_NAME]: eslintPackageName
}
);
});

if (executableResult.status !== 0) {
console.error('The eslint-bulk-suppressions command failed.');
console.error(
`The eslint-bulk-suppressions command (\`node ${args.join(' ')}\` in ${folderPath}) failed.`
);
console.error('STDOUT:');
console.error(executableResult.stdout.toString());
console.error('STDERR:');
Expand Down
2 changes: 1 addition & 1 deletion build-tests/eslint-bulk-suppressions-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@rushstack/eslint-patch": "workspace:*",
"@rushstack/heft": "workspace:*",
"@rushstack/node-core-library": "workspace:*",
"@typescript-eslint/parser": "~8.31.0",
"@typescript-eslint/parser": "~8.46.0",
"eslint": "~8.57.0",
"local-node-rig": "workspace:*",
"typescript": "~5.8.2"
Expand Down
3 changes: 1 addition & 2 deletions build-tests/heft-example-lifecycle-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,12 @@
"start": "heft build-watch",
"_phase:build": "heft run --only build -- --clean"
},
"dependencies": {},
"devDependencies": {
"@rushstack/heft": "workspace:*",
"@rushstack/heft-lint-plugin": "workspace:*",
"@rushstack/heft-typescript-plugin": "workspace:*",
"@types/node": "20.17.19",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
}
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-example-plugin-01/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@rushstack/heft-typescript-plugin": "workspace:*",
"@types/node": "20.17.19",
"@types/tapable": "1.0.6",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
}
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-example-plugin-02/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@rushstack/heft-lint-plugin": "workspace:*",
"@rushstack/heft-typescript-plugin": "workspace:*",
"@types/node": "20.17.19",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"heft-example-plugin-01": "workspace:*",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-fastify-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@rushstack/heft-typescript-plugin": "workspace:*",
"@types/heft-jest": "1.0.1",
"@types/node": "20.17.19",
"eslint": "~9.25.1",
"eslint": "~9.37.0",
"local-eslint-config": "workspace:*",
"typescript": "~5.8.2"
},
Expand Down
Loading
Loading