[terminal] Add support for onProblem notification callback to IOperationExecutionResult.problemCollector
#5382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmiddha
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
octogonz
as code owners
bmiddha
changed the title
onProblem notification callback to IOperationExecutionResult.problemCollectoronProblem notification callback to IOperationExecutionResult.problemCollector
iclanton
reviewed
Sep 30, 2025
common/changes/@rushstack/terminal/bmiddha-problem-matcher-onproblem_2025-09-29-23-40.json
Outdated
Show resolved
Hide resolved
iclanton
reviewed
Sep 30, 2025
bmiddha
force-pushed
the
bmiddha/problem-matcher-onproblem
branch
from
2a7bb27 to
023d986
Compare
bmiddha
force-pushed
the
bmiddha/problem-matcher-onproblem
branch
from
2dbdf75 to
b56d89c
Compare
dmichon-msft
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for
onProblemnotification callback toIOperationExecutionResult.problemCollector.Details
onProblemcallback is invoked when a problem is matched and finalized.get problemsno longer throws ifProblemCollectoris not closed. It now returns the problems collected so far.How it was tested
ProblemCollectorandProblemMatcherunit tests