[heft] (BREAKING CHANGE) Revert task/phase start/finish hooks to be synchronous #5381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
D4N14L,
apostolisms,
iclanton and
octogonz
as code owners
nick-pape
approved these changes
Sep 29, 2025
iclanton
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the
(task|phase)(Start|Finish)hooks to be synchronous instead of asynchronous. This is meant to be a clear indicator that these hooks are really just meant for logging in in the current runtime, not performing expensive asynchronous work (which should go on the work queue).Details
Also applies to the underlying execution engine in
@rushstack/operation-graphwith the(before|after)ExecuteOperation(Group)?properties on the execution context.How it was tested
Ran all tests in the repository, including the example lifecycle plugin that exercises these hooks.
Impacted documentation
Documentation on
(task|phase)(Start|Finish)hooks.