[lockfile-explorer] Add support for PNPM 10 #5377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octogonz
requested review from
D4N14L,
apostolisms,
dmichon-msft and
iclanton
as code owners
iclanton
approved these changes
Oct 3, 2025
| export interface IJsonLfxDependency { | ||
| name: string; | ||
| version: string; | ||
| versionPath: string; |
Member
There was a problem hiding this comment.
Maybe leave a doc comment about what this is.
Collaborator
Author
There was a problem hiding this comment.
These are just the serialized versions of the corresponding fields from LfxGraph
| dependencyType: LfxDependencyKind; | ||
| containingEntry: LfxGraphEntry; | ||
| peerDependencyMeta: IJsonPeerDependencyMeta; | ||
| versionPath: string; |
Collaborator
Author
There was a problem hiding this comment.
These all have the same meaning as the corresponding fields in LfxGraph, since they are just its inputs
|
|
||
| The lockfiles were built from this repistory: | ||
|
|
||
| https://github.com/octogonz/lockfile-explorer-edge-cases |
Member
There was a problem hiding this comment.
Why not just check them into this repo?
Collaborator
Author
There was a problem hiding this comment.
We should do that. I was deliberating about whether to make it a separate repo like https://github.com/microsoft/rush-example
common/changes/@rushstack/lockfile-explorer/octogonz-lfx-pnpm-10_2025-10-03-05-47.json
Show resolved
Hide resolved
Collaborator
Author
|
I'll address these minor points in the next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for PNPM 10 and fix lots of bugs with the lockfile parser
Details
This is the culmination of work from several recent PR's. It will be a major version bump for Lockfile Explorer.
How it was tested
Carefully analyzed the unit test cases for lockfile formats V5.4, V6.0, and V9.0
Impacted documentation
None.