[rush] add support for problem matchers #5371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmiddha
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
octogonz
as code owners
bmiddha
force-pushed
the
bmiddha/problem-matchers
branch
from
7823d10 to
4bf6519
Compare
dmichon-msft
approved these changes
Sep 22, 2025
dmichon-msft
approved these changes
Sep 24, 2025
libraries/rush-lib/src/logic/operations/IOperationExecutionResult.ts
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dmichon-msft
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for VS code / GitHub actions style problem matchers
Details
Implement the problem matchers API.
Add
ProblemCollector extends TerminalWritableto evaluate problem matchers and collect for reporting.Integrate
ProblemCollectorwith theFileErrormatchers intoOperationExecutionRecord. The problems aren't reported anywhere yet but they are available throughIOperationExecutionResult.problemCollector.getProblems()VS Code integration
FileErrorproblem matcher support to the Rushstack VS Code Extension. Tasks run by the extension will now use theFileErrorproblem matchers and surface errors to VS Code.How it was tested
Impacted documentation