[api-extractor] fix namespace support#5349
Open
adventure-yunfei wants to merge 8 commits intomicrosoft:mainfrom
Open
[api-extractor] fix namespace support#5349adventure-yunfei wants to merge 8 commits intomicrosoft:mainfrom
adventure-yunfei wants to merge 8 commits intomicrosoft:mainfrom
Conversation
…s inside namespace untouched
8696260 to
0235c5d
Compare
Collaborator
|
@adventure-yunfei Thanks for this fix! Overall it looks good to me. I will merge it after testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api-extractor generates invalid dts results for some namespace declaration cases. e.g.
import *namespaces produce malformed .d.ts rollups (withbundledPackages) #4807{};at the end #3127Details
Code changes summary:
Analyzing phase: analyze "export { A as B }" node (which should be referenced by namespace)
Emitting phase:
Fixed [api-extractor] Re-exported
import *namespaces produce malformed .d.ts rollups (withbundledPackages) #4807Fixed [api-extractor] Namespace/Module Declaration has
{};at the end #3127Fix unexpected export of actual un-exported declaration:
input:
expected output:
actual output:
How it was tested
Added a new
namespaceDeclarationtest case, and verified other test results.Impacted documentation