Skip to content

Fix some test flakiness. #5345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iclanton merged 2 commits into from
Sep 2, 2025
Merged

Fix some test flakiness. #5345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dfb04e
Fix test flakiness in node-core-library.
iclanton Aug 31, 2025
dfc26f2
Fix some test flakiness in rush-lib.
iclanton Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-tests/api-extractor-test-05/dist/tsdoc-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"toolPackages": [
{
"packageName": "@microsoft/api-extractor",
"packageVersion": "7.52.8"
"packageVersion": "7.52.11"
}
]
}
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/fix-tests_2025-08-31-02-01.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "",
"type": "none"
}
],
"packageName": "@microsoft/rush"
}
11 changes: 11 additions & 0 deletions common/changes/@rushstack/node-core-library/fix-tests_2025-08-31-01-31.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"type": "none",
"packageName": "@rushstack/node-core-library"
}
],
"packageName": "@rushstack/node-core-library",
"email": "iclanton@users.noreply.github.com"
}
3 changes: 1 addition & 2 deletions libraries/node-core-library/src/test/FileSystem.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,9 @@ describe(FileSystem.name, () => {
});

test('Should return true for an error on a file descriptor call', () => {
const buffer: Buffer = Buffer.allocUnsafeSlow(1024);
expect.assertions(1);
try {
fs.readSync(11, buffer, 0, buffer.length, -1);
fs.readFileSync(`${__dirname}/nonexistent.txt`);
Copy link
Contributor

@dmichon-msft dmichon-msft Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iclanton , this test is now no longer testing the category of issue the description says it is.

} catch (error) {
expect(FileSystem.isErrnoException(error)).toBe(true);
}
Expand Down
4 changes: 4 additions & 0 deletions libraries/rush-lib/src/cli/test/RushCommandLineParser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ describe('RushCommandLineParser', () => {
afterEach(() => {
jest.clearAllMocks();
EnvironmentConfiguration.reset();
jest
.spyOn(EnvironmentConfiguration, 'buildCacheOverrideJsonFilePath', 'get')
.mockReturnValue(undefined);
jest.spyOn(EnvironmentConfiguration, 'buildCacheOverrideJson', 'get').mockReturnValue(undefined);
});

describe('in basic repo', () => {
Expand Down
Loading