-
Notifications
You must be signed in to change notification settings - Fork 665
fix(redis): treat ignorable Redis errors as warnings #5325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iclanton
merged 9 commits into
microsoft:main
from
aramissennyeydd:sennyeya/fix-redis-error
Oct 7, 2025
Merged
fix(redis): treat ignorable Redis errors as warnings #5325
iclanton
merged 9 commits into
microsoft:main
from
aramissennyeydd:sennyeya/fix-redis-error
Oct 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramissennyeydd
commented
Aug 27, 2025
rush-plugins/rush-redis-cobuild-plugin/src/RedisCobuildLockProvider.ts
Outdated
Show resolved
Hide resolved
aramissennyeydd
commented
Aug 27, 2025
rush-plugins/rush-redis-cobuild-plugin/src/RedisCobuildLockProvider.ts
Outdated
Show resolved
Hide resolved
aramissennyeydd
commented
Aug 27, 2025
rush-plugins/rush-redis-cobuild-plugin/src/RedisCobuildLockProvider.ts
Outdated
Show resolved
Hide resolved
iclanton
approved these changes
Aug 27, 2025
2c7aaf5 to
85d78ef
Compare
Contributor
Author
|
@iclanton Is this good to merge? |
90aa07c to
99d433d
Compare
99d433d to
e228371
Compare
e228371 to
6115d95
Compare
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
6115d95 to
c0b91e7
Compare
iclanton
reviewed
Oct 7, 2025
common/changes/@microsoft/rush/sennyeya-fix-redis-error_2025-08-26-23-37.json
Outdated
Show resolved
Hide resolved
iclanton
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've been seeing intermittent CI failures caused by messages like,
We know that the underlying library
@redis/clienthandles retries but it looks like there is no.on('error'handler to listen for retryable errors so it is crashing the process. This PR addresses that by adding an.on('error'handler and configuring the retry strategy to give up after a couple of failed connection attempts (I chose 5 as a good number). This also necessitated bumping the package version to latest.Details
Added an
'error'handler to prevent the entire process from crashing due to unhandled errors. This is hidden in the docs, https://github.com/redis/node-redis#events but is definitely causing issues for us.How it was tested
Ran the
rush-redis-cobuild-integration-testlocally anddocker-compose down-ed the redis server halfway through a run. Before this change, the Rush process would immediately crash - with this change, if youdocker-compose up -dagain within the retryStrategy timeout, the process continues until success. If you keep the redis server off, the process will die with a message like,Impacted documentation