Skip to content

[rush-serve] Unref server #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmichon-msft merged 1 commit into from
Aug 26, 2025
Merged

[rush-serve] Unref server #5324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/rush-serve-unref_2025-08-26-21-30.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "[rush-serve-plugin] Allow the Rush process to exit if the server is the only active handle.",
"type": "none"
}
],
"packageName": "@microsoft/rush"
}
3 changes: 3 additions & 0 deletions rush-plugins/rush-serve-plugin/src/phasedCommandHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,9 @@ export async function phasedCommandHandler(options: IPhasedCommandHandlerOptions
webSocketServerUpgrader?.(server);

server.listen(requestedPort);
// Don't let the HTTP/2 server keep the process alive if the user asks to quit.
// TODO: use some "user wants to exit" event to close the server.
server.unref();
await once(server, 'listening');

const address: AddressInfo | undefined = server.address() as AddressInfo;
Expand Down
Loading