[rush-resolver-cache] Fix bundledDependencies in cache #5323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
D4N14L,
apostolisms,
iclanton and
octogonz
as code owners
dmichon-msft
force-pushed
the
resolver-cache-cache
branch
from
7486ecd to
a041820
Compare
iclanton
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where packages with
bundledDependencieswere persisted in the subpackage cache with incorrect data.Bug introduced in #5321 .
Details
The returned arrays are mutated during
computeResolverCacheFromLockfileAsyncto extract outbundledDependencies.Adds a
versionfield to the subpackage cache file to support ignoring the file if it is incompatible with current spec.How it was tested
Ran twice on a repo with
bundledDependenciesin packages and verified that the bundled dependencies resolve post-cache replay.Impacted documentation
None.