Skip to content

[rush] Fix performance in findOrphanedProjects #5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmichon-msft merged 1 commit into from
Aug 20, 2025
Merged

[rush] Fix performance in findOrphanedProjects #5310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/tune-prepare-async_2025-08-20-01-11.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Fix poor performance scaling during `rush install` when identifying projects in the lockfile that no longer exist.",
"type": "none"
}
],
"packageName": "@microsoft/rush"
}
12 changes: 8 additions & 4 deletions libraries/rush-lib/src/logic/pnpm/PnpmShrinkwrapFile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import type {
ResolvedDependencies
} from '@pnpm/lockfile.types';
import { convertLockfileV9ToLockfileObject } from './PnpmShrinkWrapFileConverters';
import type { IReadonlyLookupByPath } from '@rushstack/lookup-by-path';

const yamlModule: typeof import('js-yaml') = Import.lazy('js-yaml', require);

Expand Down Expand Up @@ -812,12 +813,15 @@ export class PnpmShrinkwrapFile extends BaseShrinkwrapFile {
return super.findOrphanedProjects(rushConfiguration, subspace);
}

const subspaceTempFolder: string = subspace.getSubspaceTempFolderPath();
const lookup: IReadonlyLookupByPath<RushConfigurationProject> =
rushConfiguration.getProjectLookupForRoot(subspaceTempFolder);

const orphanedProjectPaths: string[] = [];
for (const importerKey of this.getImporterKeys()) {
// PNPM importer keys are relative paths from the workspace root, which is the common temp folder
const rushProjectPath: string = path.resolve(subspace.getSubspaceTempFolderPath(), importerKey);
if (!rushConfiguration.tryGetProjectForPath(rushProjectPath)) {
orphanedProjectPaths.push(rushProjectPath);
if (!lookup.findChildPath(importerKey)) {
// PNPM importer keys are relative paths from the workspace root, which is the common temp folder
orphanedProjectPaths.push(path.resolve(subspaceTempFolder, importerKey));
}
}
return orphanedProjectPaths;
Expand Down
Loading