[rush] Add safety check to Bridge Cache plugin write action #5275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benkeen
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
octogonz
as code owners
benkeen
force-pushed
the
benkeen/bridge-cache-safety-check
branch
from
606f5ba to
b0ee77e
Compare
benkeen
changed the title
benkeen
force-pushed
the
benkeen/bridge-cache-safety-check
branch
from
b0ee77e to
29d91d0
Compare
Contributor
Author
benkeen
force-pushed
the
benkeen/bridge-cache-safety-check
branch
from
aa06cba to
64bc197
Compare
Contributor
Author
|
Hey @dmichon-msft, @iclanton mind taking a glance at this when you get a moment? Be nice to get it in. Thanks! |
Co-authored-by: David Michon <dmichon@microsoft.com>
dmichon-msft
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a optional safety check flag to the
writeaction for the Bridge Cache plugin to verify all defined output folders for a task has been created on disk in order to populate the cache entry. If there's any missing, it outputs a warning stating which folders are missing and doesn't populate the cache for that particular action.