Skip to content

[rush-lib] Fix pnpm-sync caused .modules.yaml ENOENT during install #5259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
octogonz merged 3 commits into from
Jun 23, 2025
+12 −1
Merged

[rush-lib] Fix pnpm-sync caused .modules.yaml ENOENT during install #5259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a4b92d
fix: pnpm-sync causing .modules.yaml ENOENT during install, #5201
harttle Jun 23, 2025
d6857b5
docs: add rush change
harttle Jun 23, 2025
1b94628
style: fix type lint
harttle Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/fix-pnpm-sync-modules-yaml_2025-06-23-08-37.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Fix pnpm-sync caused .modules.yaml ENOENT during install",
"type": "none"
}
],
"packageName": "@microsoft/rush"
}
3 changes: 2 additions & 1 deletion libraries/rush-lib/src/logic/base/BaseInstallManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,11 +293,12 @@ export abstract class BaseInstallManager {
if (this.rushConfiguration.isPnpm && experiments?.usePnpmSyncForInjectedDependencies) {
const pnpmLockfilePath: string = subspace.getTempShrinkwrapFilename();
const dotPnpmFolder: string = `${subspace.getSubspaceTempFolderPath()}/node_modules/.pnpm`;
const modulesFilePath: string = `${subspace.getSubspaceTempFolderPath()}/node_modules/.modules.yaml`;
Copy link
Collaborator

@octogonz octogonz Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally pnpm-sync-lib should export this as a constant. But it's not essential.


// we have an edge case here
// if a package.json has no dependencies, pnpm will still generate the pnpm-lock.yaml but not .pnpm folder
// so we need to make sure pnpm-lock.yaml and .pnpm exists before calling the pnpmSync APIs
if ((await FileSystem.existsAsync(pnpmLockfilePath)) && (await FileSystem.existsAsync(dotPnpmFolder))) {
if ((await FileSystem.existsAsync(pnpmLockfilePath)) && (await FileSystem.existsAsync(dotPnpmFolder)) && (await FileSystem.existsAsync(modulesFilePath))) {
await pnpmSyncPrepareAsync({
lockfilePath: pnpmLockfilePath,
dotPnpmFolder,
Expand Down