[heft-sass] Ensure valid d.ts output for non-identifier classnames#5233
Merged
dmichon-msft merged 1 commit intomicrosoft:mainfrom May 14, 2025
Merged
[heft-sass] Ensure valid d.ts output for non-identifier classnames#5233dmichon-msft merged 1 commit intomicrosoft:mainfrom
dmichon-msft merged 1 commit intomicrosoft:mainfrom
Conversation
dmichon-msft
requested review from
D4N14L,
apostolisms,
iclanton and
octogonz
as code owners
iclanton
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where heft-sass-plugin would produce invalid .d.ts outputs for classnames that contain non-identifier characters.
Details
If
exportAsDefault: falseand a classname contains invalid identifier characters, this will throw. ForexportAsDefault: true, the classnames will be quoted and JSON escaped.How it was tested
Added a classname with
-intoheft-sass-test.Impacted documentation
None in particular.