[heft-sass] Ignore SASS partials in module classifier#5225
Merged
dmichon-msft merged 2 commits intomicrosoft:mainfrom May 13, 2025
Merged
[heft-sass] Ignore SASS partials in module classifier#5225dmichon-msft merged 2 commits intomicrosoft:mainfrom
dmichon-msft merged 2 commits intomicrosoft:mainfrom
Conversation
dmichon-msft
requested review from
D4N14L,
apostolisms,
iclanton and
octogonz
as code owners
bmiddha
approved these changes
May 12, 2025
D4N14L
approved these changes
May 12, 2025
iclanton
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where the heft-sass-plugin would throw errors if it encountered a SASS partial that it could not identify as being a global or CSS module.
Details
Overrides the classifier to always treat SASS partials as "not modules" since they cannot be directly imported from script.
How it was tested
Updated
heft-sass-testto require files to be marked as.module.scssor.global.scssand omitted the specifier on partials. Verified that the test succeeds despite the partials not specifying a type, since they aren't ambiguous.Impacted documentation
Possibly the file extension classifier? Doesn't affect the output behavior, only removes irrelevant errors.