Skip to content

[rush] Fix path parsing issue when running rush bridge-package #5224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iclanton merged 2 commits into from
May 12, 2025
Merged

[rush] Fix path parsing issue when running rush bridge-package #5224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce892cb
fix: parse path
L-Qun May 8, 2025
e11475f
fix: ci
L-Qun May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/feat-add-cursor-rules_2025-05-08-12-27.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Fix path parsing issue when running rush bridge-package",
"type": "none"
}
],
"packageName": "@microsoft/rush"
}
7 changes: 2 additions & 5 deletions libraries/rush-lib/src/utilities/HotlinkManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@ import {
type INodePackageJson,
type IPackageJsonDependencyTable
} from '@rushstack/node-core-library';
import type { DependencyPath } from '@pnpm/dependency-path';
import { PackageExtractor } from '@rushstack/package-extractor';
import { pnpmSyncUpdateFileAsync, pnpmSyncCopyAsync, type ILogMessageCallbackOptions } from 'pnpm-sync-lib';
import { parse } from '@pnpm/dependency-path';
import * as semver from 'semver';

import type { RushConfiguration } from '../api/RushConfiguration';
Expand Down Expand Up @@ -196,9 +194,8 @@ export class HotlinkManager {
);
const packageSourcePathSet: Set<string> = new Set();
for (const dirName of subDirectories) {
const parsedDependency: DependencyPath = parse(dirName);
if (parsedDependency?.name === packageName) {
const packageSourcePath: string = `${consumerPackagePnpmDependenciesFolderPath}/${dirName}/${RushConstants.nodeModulesFolderName}/${packageName}`;
const packageSourcePath: string = `${consumerPackagePnpmDependenciesFolderPath}/${dirName}/${RushConstants.nodeModulesFolderName}/${packageName}`;
if (await FileSystem.existsAsync(packageSourcePath)) {
const { version } = await JsonFile.loadAsync(`${packageSourcePath}/${FileConstants.PackageJson}`);
if (semver.satisfies(version, versionRange)) {
packageSourcePathSet.add(packageSourcePath);
Expand Down