Fix 'select' method to allow deselecting selection by adiletelf · Pull Request #129 · microsoft/powerbi-visuals-utils-testutils

adiletelf · 2024-12-12T08:51:46Z

Fix 'select' method to allow deselecting selection
Check if 'callback' is defined in MockISelectionManager (as in API)
Add tests for MockISelectionManager

Please, view the source code for 'select' method.

AleksSavelev

I see that you copied select method from selectionManager and this is correct, but I'm not sure if we should copy spaghetti code, what do you think?

AleksSavelev · 2024-12-12T10:08:45Z

src/mocks/mockISelectionManager.ts

+                resolve(this.selectionIds);
+            }) as any;
+        }
+


I see a lot of If else blocks and all of them have the same this.selectionIds = selectionIds

If this is right, you can make it much easier:

if(multiSelect){ ...all your ifs here } else { this.selectionIds = selectionIds }

I refactored the code to make it more readable.

AleksSavelev · 2024-12-12T10:09:08Z

src/mocks/mockISelectionManager.ts

-        // if no multiselect reset current selection and save new passed selections;
-        if (!multiSelect) {
-            this.selectionIds = selectionIds;
+        if (selectionIds.length < 1) {


selectionIds.length === 0

AleksSavelev · 2024-12-12T10:11:46Z

src/mocks/mockISelectionManager.ts


    public simutateSelection(selections: ISelectionId[]): void {
-        this.callback(selections);
+        if (this.callback && typeof this.callback === "function") {


type guard is enough here, it also checks for undefined

AleksSavelev · 2024-12-12T10:14:44Z

test/mocks/mockISelectionManagerTest.ts

+
+            const selectedIds: ISelectionId[] = selectionManager.getSelectionIds();
+            expect(selectedIds).toHaveSize(3);
+            expect(selectedIds[0].equals(selectionId0)).toBeTruthy();


expect(selectedIds[0]).toEqual(selectionId0)

AleksSavelev · 2024-12-12T10:16:33Z

test/mocks/mockISelectionManagerTest.ts

+            const selectionId0: ISelectionId = createSelectionId("0");
+            const selectionId1: ISelectionId = createSelectionId("1");
+            const selectionId2: ISelectionId = createSelectionId("2");


You can create a variable with these selectionIds and then compare it with the result using toEqual

AleksSavelev · 2024-12-12T10:18:44Z

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 6.1.2
+* Fix 'select' method to allow deselecting selection


Fix 'select' method in MockISelectionManager to allow deselecting selection

AleksSavelev · 2024-12-12T10:21:56Z

src/mocks/mockISelectionManager.ts

+                this.selectionIds = this.selectionIds.filter(x => !selectionIds[0].equals(x));
+            } else {
+                // if multiSelect is off, the selected item is the new selectedId, else deselect the selection
+                this.selectionIds = selectionIds.length > 1 ? selectionIds : [];


Here would be always an empty array

You're right, it's the expected behavior too. Fixed.

…handling and update tests for consistency

adiletelf added 3 commits December 12, 2024 14:38

Fix 'select' method to allow deselecting selection

fde7bb9

Check if 'callback' is defined in MockISelectionManager

37463f2

Add tests for MockISelectionManager

bfbefb3

AleksSavelev requested changes Dec 12, 2024

View reviewed changes

Refactor select method in MockISelectionManager to improve selection …

0e8eb35

…handling and update tests for consistency

		@@ -1,3 +1,7 @@
		## 6.1.2
		* Fix 'select' method to allow deselecting selection

Conversation

adiletelf commented Dec 12, 2024

Uh oh!

AleksSavelev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adiletelf Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adiletelf Dec 13, 2024 •

edited

Loading