chore: generate cli help in-build #38945
Conversation
pavelfeldman
force-pushed
the
better_help_cli
branch
from
5688d52 to
6670ca2
Compare
pavelfeldman
force-pushed
the
better_help_cli
branch
from
6670ca2 to
e4a5a2f
Compare
|
|
||
| const fileName = path.resolve(__dirname, '../packages/playwright/lib/mcp/terminal/help.json'); | ||
| console.log('Writing ', path.relative(process.cwd(), fileName)); | ||
| fs.writeFileSync(fileName, JSON.stringify(generateHelpJSON(), null, 2)); |
There was a problem hiding this comment.
Just a recommendation: Consider adding error handling here to make build failures more obvious:
try {
fs.writeFileSync(fileName, JSON.stringify(generateHelpJSON(), null, 2));
console.log('✓ Successfully wrote', path.relative(process.cwd(), fileName));
} catch (error) {
console.error('✗ Failed to write help file:', error.message);
process.exit(1);
}This will make it clearer if the file write fails during the build process.
| nohup.out | ||
| .trace | ||
| .tmp | ||
| .playwright-cli |
There was a problem hiding this comment.
Should we also add the generated help file here?
There was a problem hiding this comment.
Since help.json is now auto-generated during build, it probably shouldn't be checked into version control.
Test results for "tests 1"8 failed 7 flaky34658 passed, 695 skipped Merge workflow run. |
Test results for "MCP"9 failed 3105 passed, 305 skipped Merge workflow run. |
3 participants
No description provided.