Only create exception objects if we're going to throw them#66
Draft
raneashay wants to merge 1 commit intomicrosoft:mainfrom
Draft
Only create exception objects if we're going to throw them#66raneashay wants to merge 1 commit intomicrosoft:mainfrom
throw them#66raneashay wants to merge 1 commit intomicrosoft:mainfrom
Conversation
As I understand, every time an exception object is created, the constructor calls `fillInStackTrace()`, which has to walk the call stack to record every frame. This is expensive, but it's also unnecessary if the exception is never thrown. There are a few instances in various parts of the JDK libraries where we create an exception in the dominator block but don't always throw it. This patch fixes those cases so that if the exception is not going to be thrown, it is never created in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I understand, every time an exception object is created, the
constructor calls
fillInStackTrace(), which has to walk the call stackto record every frame. This is expensive, but it's also unnecessary if
the exception is never thrown. There are a few instances in various
parts of the JDK libraries where we create an exception in the dominator
block but don't always throw it. This patch fixes those cases so that
if the exception is not going to be thrown, it is never created in the
first place.