Skip to content

FIX: Updates TimeZone support for DATETIMEOFFSET type, fixes incorrect Now() in USE_TZ=True cases. #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trolldbois wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

FIX: Updates TimeZone support for DATETIMEOFFSET type, fixes incorrect Now() in USE_TZ=True cases. #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b959360
handle datetimeoffset timezone part
trolldbois Dec 26, 2025
5493ebb
Fix Now() to be timezone-aware
trolldbois Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mssql/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ def handle_datetimeoffset(dto_value):
# Decode bytes returned from SQL Server
# source: https://github.com/mkleehammer/pyodbc/wiki/Using-an-Output-Converter-function
tup = struct.unpack("<6hI2h", dto_value) # e.g., (2017, 3, 16, 10, 35, 18, 500000000)
return datetime.datetime(tup[0], tup[1], tup[2], tup[3], tup[4], tup[5], tup[6] // 1000)
return datetime.datetime(tup[0], tup[1], tup[2], tup[3], tup[4], tup[5], tup[6] // 1000,
datetime.timezone(datetime.timedelta(hours=tup[7], minutes=tup[8])))


class DatabaseWrapper(BaseDatabaseWrapper):
Expand Down
8 changes: 5 additions & 3 deletions mssql/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,11 @@ def sqlserver_exists(self, compiler, connection, template=None, **extra_context)
return sql, params

def sqlserver_now(self, compiler, connection, **extra_context):
return self.as_sql(
compiler, connection, template="SYSDATETIME()", **extra_context
)
if settings.USE_TZ:
return self.as_sql(compiler, connection, template="SYSDATETIMEOFFSET()", **extra_context)
else:
# continue using SYSDATETIME to get the DB local time when django is not TZ aware
return self.as_sql(compiler, connection, template="SYSDATETIME()", **extra_context)

def sqlserver_lookup(self, compiler, connection):
# MSSQL doesn't allow EXISTS() to be compared to another expression
Expand Down