-
Notifications
You must be signed in to change notification settings - Fork 340
Add Azure Table list back #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds back the Azure Table list tool functionality under Azure.Mcp.Tools.Table, providing the azmcp_table_list command to list all tables in an Azure Storage account.
Key changes include:
- Implementation of a new Azure Table tool with list functionality
- Complete test coverage with both unit and live tests
- Integration into the Azure MCP Server with proper documentation
Reviewed Changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Table/src/* | Core implementation of the Table tool including commands, services, and options |
| tools/Azure.Mcp.Tools.Table/tests/* | Comprehensive test coverage with unit tests and live tests |
| servers/Azure.Mcp.Server/src/Program.cs | Integration of Table tool into the server |
| servers/Azure.Mcp.Server/docs/* | Documentation updates for the new table commands |
| Directory.Packages.props | Addition of Azure.Data.Tables package dependency |
| AzureMcp.sln | Solution file updates to include new Table tool projects |
tools/Azure.Mcp.Tools.Table/tests/Azure.Mcp.Tools.Table.LiveTests/TableCommandTests.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.Table/tests/Azure.Mcp.Tools.Table.LiveTests/TableCommandTests.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.Table/tests/Azure.Mcp.Tools.Table.LiveTests/TableCommandTests.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.Tables/tests/Azure.Mcp.Tools.Tables.LiveTests/TablesCommandTests.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.Table/tests/Azure.Mcp.Tools.Table.UnitTests/TableListCommandTests.cs
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.Tables/tests/Azure.Mcp.Tools.Tables.LiveTests/TablesCommandTests.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.Tables/tests/Azure.Mcp.Tools.Tables.LiveTests/TablesCommandTests.cs
Outdated
Show resolved
Hide resolved
|
I wonder if it maybe better to create 2 separate tools, one is to list cosmos db tables, the other is to list storage account tables. |
vcolin7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commands look good. I just added a couple of comments on files under /ToolDescriptionEvaluator. Also, I think we can do without the tools.json in the same fashion I talked about results.json.
We will support Storage for the time being.
What does this PR do?
Adds back Azure Table list tool under
Azure.Mcp.Tools.Table,azmcp_table_list.GitHub issue number?
Fixes #675
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.md