-
Notifications
You must be signed in to change notification settings - Fork 340
Added a TestTimeoutInMinutes parameter to common.yml and build.yml files
#1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a configurable TestTimeoutInMinutes parameter to address timeout issues for long-running tests. The parameter provides a workaround for test timeout problems by allowing customization of the timeout duration for unit and recorded tests.
- Added
TestTimeoutInMinutesparameter with a default value of 30 minutes across all server build configurations - Updated the common pipeline template to use the parameterized timeout instead of a hardcoded value
- Ensures consistent timeout configuration across Azure, Fabric, and Template MCP servers
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| servers/Template.Mcp.Server/build.yml | Added TestTimeoutInMinutes parameter definition and passed it to the common template |
| servers/Fabric.Mcp.Server/build.yml | Added TestTimeoutInMinutes parameter definition and passed it to the common template |
| servers/Azure.Mcp.Server/build.yml | Added TestTimeoutInMinutes parameter definition and passed it to the common template |
| eng/pipelines/templates/common.yml | Added TestTimeoutInMinutes parameter definition and replaced hardcoded timeout value with the parameter |
2060d14 to
3c27a7e
Compare
alzimmermsft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do any of the timeouts need to be increased past 30 minutes, given they were failing before and the limit didn't increase
I like keeping them 30m here, with the new allowed override at queue time |
What does this PR do?
As of right now, there is no way for passing down a polling interval to Test Proxy as mentioned in #1426, so this PR adds a way to allow customizing the timeout for test runs as a workaround for some tests taking too long.
Also updates the CHANGELOGs for the
2.0.0-beta.9release that's blocked by the aforementioned long-running tests.GitHub issue number?
N/A
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline