Skip to content

Conversation

@vcolin7
Copy link
Contributor

@vcolin7 vcolin7 commented Jan 7, 2026

What does this PR do?

As of right now, there is no way for passing down a polling interval to Test Proxy as mentioned in #1426, so this PR adds a way to allow customizing the timeout for test runs as a workaround for some tests taking too long.

Also updates the CHANGELOGs for the 2.0.0-beta.9 release that's blocked by the aforementioned long-running tests.

GitHub issue number?

N/A

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@vcolin7 vcolin7 self-assigned this Jan 7, 2026
Copilot AI review requested due to automatic review settings January 7, 2026 21:56
@vcolin7 vcolin7 requested review from a team as code owners January 7, 2026 21:56
@github-project-automation github-project-automation bot moved this to Untriaged in Azure MCP Server Jan 7, 2026
@vcolin7 vcolin7 requested a review from hallipr January 7, 2026 21:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a configurable TestTimeoutInMinutes parameter to address timeout issues for long-running tests. The parameter provides a workaround for test timeout problems by allowing customization of the timeout duration for unit and recorded tests.

  • Added TestTimeoutInMinutes parameter with a default value of 30 minutes across all server build configurations
  • Updated the common pipeline template to use the parameterized timeout instead of a hardcoded value
  • Ensures consistent timeout configuration across Azure, Fabric, and Template MCP servers

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
servers/Template.Mcp.Server/build.yml Added TestTimeoutInMinutes parameter definition and passed it to the common template
servers/Fabric.Mcp.Server/build.yml Added TestTimeoutInMinutes parameter definition and passed it to the common template
servers/Azure.Mcp.Server/build.yml Added TestTimeoutInMinutes parameter definition and passed it to the common template
eng/pipelines/templates/common.yml Added TestTimeoutInMinutes parameter definition and replaced hardcoded timeout value with the parameter

@vcolin7 vcolin7 force-pushed the add-ci-test-timeout-parameter branch from 2060d14 to 3c27a7e Compare January 7, 2026 22:15
Copy link
Contributor

@alzimmermsft alzimmermsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of the timeouts need to be increased past 30 minutes, given they were failing before and the limit didn't increase

@hallipr
Copy link
Member

hallipr commented Jan 7, 2026

Do any of the timeouts need to be increased past 30 minutes, given they were failing before and the limit didn't increase

I like keeping them 30m here, with the new allowed override at queue time

@vcolin7 vcolin7 merged commit dd5a1f2 into main Jan 7, 2026
26 checks passed
@vcolin7 vcolin7 deleted the add-ci-test-timeout-parameter branch January 7, 2026 22:58
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Azure MCP Server Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants