Skip to content

Migrate EventHubs tests to recorded tests #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
g2vinay merged 3 commits into from
Jan 7, 2026
Merged

Migrate EventHubs tests to recorded tests #1438

g2vinay merged 3 commits into from
Jan 7, 2026

Conversation

@g2vinay
Copy link
Contributor

@g2vinay g2vinay commented Jan 6, 2026 •
edited
Loading

Migrates EventHubs tests to recorded tests
Resolves #1285

@github-project-automation github-project-automation bot moved this to Untriaged in Azure MCP Server Jan 6, 2026
@g2vinay g2vinay marked this pull request as ready for review January 6, 2026 19:18
@g2vinay g2vinay requested review from a team as code owners January 6, 2026 19:18
Copilot AI reviewed Jan 6, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates EventHubs live tests to use the recorded test infrastructure, enabling tests to run in Record/Playback modes in addition to Live mode.

Key Changes:

  • Migrated test class from CommandTestsBase to RecordedCommandTestsBase with required TestProxyFixture parameter
  • Added assets.json file to configure test proxy settings for recording/playback
  • Updated test assertions to work with sanitized values in playback mode by checking for presence rather than exact matches

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.

File Description
assets.json New file configuring test proxy settings with assets repository and tag information
EventHubsCommandTests.cs Migrated to RecordedCommandTestsBase, added sanitizer configurations, updated resource naming for record/playback compatibility, modified assertions to handle sanitized values, and added unused SanitizeAndRecord helper method

@g2vinay g2vinay merged commit 5b3d8eb into microsoft:main Jan 7, 2026
52 checks passed
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Azure MCP Server Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@anuchandy anuchandy anuchandy approved these changes

@jongio jongio Awaiting requested review from jongio jongio is a code owner automatically assigned from microsoft/azure-mcp

@vukelich vukelich Awaiting requested review from vukelich vukelich is a code owner automatically assigned from microsoft/azure-mcp

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner automatically assigned from microsoft/azure-mcp

@conniey conniey Awaiting requested review from conniey conniey is a code owner automatically assigned from microsoft/azure-mcp

@JonathanCrd JonathanCrd Awaiting requested review from JonathanCrd JonathanCrd is a code owner automatically assigned from microsoft/azure-mcp

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu chidozieononiwu is a code owner automatically assigned from microsoft/azure-mcp

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner automatically assigned from microsoft/azure-mcp

Assignees

No one assigned

Labels

None yet

Projects

Azure MCP Server
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate Azure.Mcp.Tools.EventHubs.LiveTests LiveTests to Recorded Tests

2 participants

@g2vinay @anuchandy