Migrate EventGrid tests to recorded framework #1425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g2vinay
force-pushed
the
migrate-eventgrid-to-recorded-tests
branch
from
bf4686d to
c086324
Compare
g2vinay
requested review from
JonathanCrd,
chidozieononiwu,
conniey,
Copilot,
hallipr,
jongio,
joshfree and
vukelich
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates EventGrid live tests to use the recorded test framework, enabling test recording and playback functionality for improved test reliability and CI/CD performance.
Key Changes:
- Converted test class from
CommandTestsBasetoRecordedCommandTestsBasewith test proxy fixture support - Added deterministic test data using
RegisterOrRetrieveVariablefor all time-based and GUID values - Implemented optional
IHttpClientFactoryinjection to enable test proxy recording for EventGrid publisher clients
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tools/Azure.Mcp.Tools.EventGrid/tests/Azure.Mcp.Tools.EventGrid.LiveTests/assets.json |
Added assets configuration file for test recordings repository integration |
tools/Azure.Mcp.Tools.EventGrid/tests/Azure.Mcp.Tools.EventGrid.LiveTests/EventGridCommandTests.cs |
Migrated test class to RecordedCommandTestsBase, added sanitizers for sensitive data, and made all tests deterministic |
tools/Azure.Mcp.Tools.EventGrid/src/Services/IEventGridService.cs |
Added optional IHttpClientFactory parameter to PublishEventAsync method signature |
tools/Azure.Mcp.Tools.EventGrid/src/Services/EventGridService.cs |
Implemented logic to use IHttpClientFactory when provided to create test proxy-aware EventGrid publisher clients |
tools/Azure.Mcp.Tools.EventGrid/src/Commands/Events/EventsPublishCommand.cs |
Added logic to optionally retrieve and pass IHttpClientFactory to the service layer |
…support and comprehensive sanitization
g2vinay
force-pushed
the
migrate-eventgrid-to-recorded-tests
branch
from
7ddceed to
3f6a56e
Compare
tools/Azure.Mcp.Tools.EventGrid/src/Services/EventGridService.cs
Outdated
Show resolved
Hide resolved
...Azure.Mcp.Tools.EventGrid/tests/Azure.Mcp.Tools.EventGrid.LiveTests/EventGridCommandTests.cs
Show resolved
Hide resolved
alzimmermsft
approved these changes
Jan 6, 2026
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure MCP Server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates EventGrid live tests to recorded framework.
Resolves #1284