Allow Deploy Service to be recordable
#1414
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al livetests so I don't know if we can trust my code changes
scbedd
requested review from
alzimmermsft,
hallipr,
jongio,
joshfree,
sandeep-sen,
vukelich and
weshaggard
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the Deploy service recordable for testing by transitioning from live tests to recorded tests. The changes follow the established pattern for enabling test recording/playback functionality using the Azure SDK Test Proxy.
Key Changes:
- Updated
DeployCommandTeststo inherit fromRecordedCommandTestsBasewith proper fixture injection - Refactored client instantiation to use dependency injection pattern, passing pre-configured
ArmClientandLogsQueryClientinstances - Added
assets.jsonconfiguration file for test recording management
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Deploy/tests/Azure.Mcp.Tools.Deploy.LiveTests/assets.json | Added test recording asset configuration with proper TagPrefix matching the project name |
| tools/Azure.Mcp.Tools.Deploy/tests/Azure.Mcp.Tools.Deploy.LiveTests/DeployCommandTests.cs | Re-parented test class from CommandTestsBase to RecordedCommandTestsBase with TestProxyFixture injection |
| tools/Azure.Mcp.Tools.Deploy/src/Services/DeployService.cs | Added CreateLogsQueryClientAsync method to create properly configured client with recording transport |
| tools/Azure.Mcp.Tools.Deploy/src/Services/Util/AzdResourceLogService.cs | Updated to accept pre-configured ArmClient and LogsQueryClient instead of creating them internally |
| tools/Azure.Mcp.Tools.Deploy/src/Services/Util/AzdAppLogRetriever.cs | Refactored to use dependency injection for ArmClient and LogsQueryClient, eliminating internal client creation and nullable fields |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1283
@qianwens , there doesn't seem to be functional query tests in the livetest set, so I don't know if I can trust my code changes. It compiles and logically it makes sense, but I need to exercise actual functionalities. Can you please help me verify? (or tell me how to verify)