Open
Conversation
* Dockerfile now clones and installs new DPDK * Also our internal documentation suggests using DPDK 23.11 Signed-off-by: Alireza Sanaee sarsanaee@gmail.com
marinosi
reviewed
Jan 12, 2024
src/include/dpdk.h
Outdated
| #include <ether.h> | ||
| #include <packet_pool.h> | ||
| #include <rte_bus_pci.h> | ||
| // #include <rte_bus_pci.h> |
Collaborator
There was a problem hiding this comment.
Please completely remove any unneeded headers/code.
Signed-off-by: Alireza Sanaee <sarsanaee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is not really ready right now, but it compiles and runs.
I have created this pull request to start having a discussion on how we would want to do some of the stuff that I may have questions about.
There is an issue with parsing the DPDK PCI address in newer versions of DPDK that we should have a discussion about how to do best here.
Also, there are a little bit more changes needed in our documentation. That I will do once we finish the PCI address parsing.
Thanks,
Alireza